+ checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: checkpatch: add check for keyword 'boolean' in Kconfig definitions
has been added to the -mm tree.  Its filename is
     checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Christoph Jaeger <cj@xxxxxxxxx>
Subject: checkpatch: add check for keyword 'boolean' in Kconfig definitions

Discourage the use of keyword 'boolean' for type definition attributes of
config options as support for it will be dropped later on.

See http://lkml.kernel.org/r/cover.1418003065.git.cj@xxxxxxxxx

Signed-off-by: Christoph Jaeger <cj@xxxxxxxxx>
Suggested-by: Daniel Borkmann <dborkman@xxxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Acked-by: Paul Bolle <pebolle@xxxxxxxxxx>
Tested-by: Paul Bolle <pebolle@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 scripts/checkpatch.pl |    7 +++++++
 1 file changed, 7 insertions(+)

diff -puN scripts/checkpatch.pl~checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions
+++ a/scripts/checkpatch.pl
@@ -2357,6 +2357,13 @@ sub process {
 			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n";);
 		}
 
+# discourage the use of boolean for type definition attributes of Kconfig options
+		if ($realfile =~ /Kconfig/ &&
+		    $line =~ /^\+\s*\bboolean\b/) {
+			WARN("CONFIG_TYPE_BOOLEAN",
+			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
+		}
+
 		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
 		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
 			my $flag = $1;
_

Patches currently in -mm which might be from cj@xxxxxxxxx are

checkpatch-add-check-for-keyword-boolean-in-kconfig-definitions.patch
linux-next.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux