The patch titled
Subject: checkpatch: fix UNNECESSARY_KERN_LEVEL false positive
has been added to the -mm tree. Its filename is
checkpatch-fix-unnecessary_kern_level-false-positive.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-fix-unnecessary_kern_level-false-positive.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-fix-unnecessary_kern_level-false-positive.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Subject: checkpatch: fix UNNECESSARY_KERN_LEVEL false positive
KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once.
(Except perhaps in the sense that you could use e.g. pr_err_ratelimited
or pr_err_once, but that would apply to printk as well).
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
Acked-by: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN scripts/checkpatch.pl~checkpatch-fix-unnecessary_kern_level-false-positive scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-fix-unnecessary_kern_level-false-positive
+++ a/scripts/checkpatch.pl
@@ -4545,7 +4545,7 @@ sub process {
}
# check for logging functions with KERN_<LEVEL>
- if ($line !~ /printk\s*\(/ &&
+ if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
$line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
my $level = $1;
if (WARN("UNNECESSARY_KERN_LEVEL",
_
Patches currently in -mm which might be from pbonzini@xxxxxxxxxx are
origin.patch
checkpatch-fix-unnecessary_kern_level-false-positive.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
