The patch titled
Subject: rtc/ab8500: set uie_unsupported flag
has been added to the -mm tree. Its filename is
rtc-ab8500-set-uie_unsupported-flag.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/rtc-ab8500-set-uie_unsupported-flag.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/rtc-ab8500-set-uie_unsupported-flag.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Xunlei Pang <pang.xunlei@xxxxxxxxxx>
Subject: rtc/ab8500: set uie_unsupported flag
Currently, ab8500 doesn't set uie_unsupported of rtc_device, while it
doesn't support UIE, see ab8500_rtc_set_alarm().
Thus, when going through rtc_update_irq_enable()->rtc_timer_enqueue(),
there's a chance it has an alarm timer1 queued before which is going to
fired, so this update timer2 will be queued because it isn't the leftmost
one, which means rtc_timer_enqueue() will return 0.
This will result in two problems:
1) UIE EMUL will not be used.
2) When the alarm timer1 is fired, in rtc_timer_do_work() timer2 will
fail to set the alarm time, so this rtc will disfunctional due to
timer2 with the earliest expires in the timerqueue.
So, rtc drivers must set this flag if they don't support UIE.
Signed-off-by: Xunlei Pang <pang.xunlei@xxxxxxxxxx>
Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
Cc: John Stultz <john.stultz@xxxxxxxxxx>
Cc: Arnd Bergmann <arnd.bergmann@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-ab8500.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/rtc/rtc-ab8500.c~rtc-ab8500-set-uie_unsupported-flag drivers/rtc/rtc-ab8500.c
--- a/drivers/rtc/rtc-ab8500.c~rtc-ab8500-set-uie_unsupported-flag
+++ a/drivers/rtc/rtc-ab8500.c
@@ -504,6 +504,8 @@ static int ab8500_rtc_probe(struct platf
return err;
}
+ rtc->uie_unsupported = 1;
+
return 0;
}
_
Patches currently in -mm which might be from pang.xunlei@xxxxxxxxxx are
rtc-ab8500-set-uie_unsupported-flag.patch
rtc-refine-rtc_timer_do_work-to-consider-other-set-alarm-failures.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
