The patch titled Subject: mm/memcontrol.c: remove unused mem_cgroup_lru_names_not_uptodate() has been added to the -mm tree. Its filename is mm-memcontrolc-cleaning-up-function-that-are-not-used-anywhere.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-memcontrolc-cleaning-up-function-that-are-not-used-anywhere.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-memcontrolc-cleaning-up-function-that-are-not-used-anywhere.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> Subject: mm/memcontrol.c: remove unused mem_cgroup_lru_names_not_uptodate() Remove unused mem_cgroup_lru_names_not_uptodate() and move BUILD_BUG_ON() to the beginning of memcg_stat_show(). This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/memcontrol.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff -puN mm/memcontrol.c~mm-memcontrolc-cleaning-up-function-that-are-not-used-anywhere mm/memcontrol.c --- a/mm/memcontrol.c~mm-memcontrolc-cleaning-up-function-that-are-not-used-anywhere +++ a/mm/memcontrol.c @@ -3692,11 +3692,6 @@ static int memcg_numa_stat_show(struct s } #endif /* CONFIG_NUMA */ -static inline void mem_cgroup_lru_names_not_uptodate(void) -{ - BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS); -} - static int memcg_stat_show(struct seq_file *m, void *v) { struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m)); @@ -3704,6 +3699,8 @@ static int memcg_stat_show(struct seq_fi struct mem_cgroup *mi; unsigned int i; + BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS); + for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) { if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account) continue; _ Patches currently in -mm which might be from rickard_strandqvist@xxxxxxxxxxxxxxxxxx are mm-memcontrolc-cleaning-up-function-that-are-not-used-anywhere.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html