The patch titled Subject: ocfs2: remove bogus NULL check in ocfs2_move_extents() has been added to the -mm tree. Its filename is ocfs2-remove-bogus-null-check-in-ocfs2_move_extents.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/ocfs2-remove-bogus-null-check-in-ocfs2_move_extents.patch echo and later at echo http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-remove-bogus-null-check-in-ocfs2_move_extents.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Subject: ocfs2: remove bogus NULL check in ocfs2_move_extents() "inode" isn't NULL here, and also we dereference it on the previous line so static checkers get annoyed. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: Mark Fasheh <mfasheh@xxxxxxxx> Cc: Joel Becker <jlbec@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ocfs2/move_extents.c | 3 --- 1 file changed, 3 deletions(-) diff -puN fs/ocfs2/move_extents.c~ocfs2-remove-bogus-null-check-in-ocfs2_move_extents fs/ocfs2/move_extents.c --- a/fs/ocfs2/move_extents.c~ocfs2-remove-bogus-null-check-in-ocfs2_move_extents +++ a/fs/ocfs2/move_extents.c @@ -904,9 +904,6 @@ static int ocfs2_move_extents(struct ocf struct buffer_head *di_bh = NULL; struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); - if (!inode) - return -ENOENT; - if (ocfs2_is_hard_readonly(osb) || ocfs2_is_soft_readonly(osb)) return -EROFS; _ Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are ocfs2-fix-an-off-by-one-bug_on-statement.patch ocfs2-remove-bogus-null-check-in-ocfs2_move_extents.patch exit-reparent-cleanup-the-changing-of-parent-fix.patch checkpatch-add-strict-pointer-comparison-to-null-test.patch checkpatch-add-ability-to-fix-coalesce-string-fragments-on-multiple-lines.patch rtc-pcf8563-remove-leftover-code.patch rtc-pcf8563-fix-write-of-invalid-bits-to-st2-reg.patch rtc-pcf8563-fix-wrong-time-from-read_alarm.patch rtc-pcf8563-handle-consequeces-of-lacking-second-alarm-reg.patch rtc-pcf8563-save-battery-power.patch rtc-pcf8563-clear-expired-alarm-at-boot-time.patch decompress_bunzip2-off-by-one-in-get_next_block.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html