The patch titled
Subject: mm/zswap: delete unnecessary check before calling free_percpu()
has been added to the -mm tree. Its filename is
mm-zswap-deletion-of-an-unnecessary-check-before-the-function-call-free_percpu.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-zswap-deletion-of-an-unnecessary-check-before-the-function-call-free_percpu.patch
echo and later at
echo http://ozlabs.org/~akpm/mmotm/broken-out/mm-zswap-deletion-of-an-unnecessary-check-before-the-function-call-free_percpu.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Subject: mm/zswap: delete unnecessary check before calling free_percpu()
free_percpu() tests whether its argument is NULL and then returns
immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Cc: Seth Jennings <sjennings@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/zswap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN mm/zswap.c~mm-zswap-deletion-of-an-unnecessary-check-before-the-function-call-free_percpu mm/zswap.c
--- a/mm/zswap.c~mm-zswap-deletion-of-an-unnecessary-check-before-the-function-call-free_percpu
+++ a/mm/zswap.c
@@ -152,8 +152,7 @@ static int __init zswap_comp_init(void)
static void __init zswap_comp_exit(void)
{
/* free percpu transforms */
- if (zswap_comp_pcpu_tfms)
- free_percpu(zswap_comp_pcpu_tfms);
+ free_percpu(zswap_comp_pcpu_tfms);
}
/*********************************
_
Patches currently in -mm which might be from elfring@xxxxxxxxxxxxxxxxxxxxx are
mm-zswap-deletion-of-an-unnecessary-check-before-the-function-call-free_percpu.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
