The patch titled scsi: remove unnecessary check in drivers/scsi/sg.c has been added to the -mm tree. Its filename is remove-unnecessary-check-in-drivers-scsi-sgc.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: scsi: remove unnecessary check in drivers/scsi/sg.c From: Eric Sesterhenn <snakebyte@xxxxxx> coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx> Cc: Douglas Gilbert <dougg@xxxxxxxxxx> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/scsi/sg.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/sg.c~remove-unnecessary-check-in-drivers-scsi-sgc drivers/scsi/sg.c --- a/drivers/scsi/sg.c~remove-unnecessary-check-in-drivers-scsi-sgc +++ a/drivers/scsi/sg.c @@ -1828,7 +1828,7 @@ sg_build_indirect(Sg_scatter_hold * schp int blk_size = buff_size; struct page *p = NULL; - if ((blk_size < 0) || (!sfp)) + if (blk_size < 0) return -EFAULT; if (0 == blk_size) ++blk_size; /* don't know why */ _ Patches currently in -mm which might be from snakebyte@xxxxxx are git-dvb.patch git-gfs2.patch git-intelfb.patch git-netdev-all.patch signedness-issue-in-drivers-scsi-iprc.patch signedness-issue-in-drivers-scsi-osstc.patch remove-unnecessary-check-in-drivers-scsi-sgc.patch uninitialized-variable-in-drivers-net-wan-syncpppc.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html