The patch titled Subject: rtc: pcf8563: save battery power has been added to the -mm tree. Its filename is rtc-pcf8563-save-battery-power.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/rtc-pcf8563-save-battery-power.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/rtc-pcf8563-save-battery-power.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jan Kardell <jan.kardell@xxxxxxxxxx> Subject: rtc: pcf8563: save battery power According to Haoyu hym8563 datasheet this saves som power. Might be importat to battery life. And maybe it works for the NXP part as well. Signed-off-by: Jan Kardell <jan.kardell@xxxxxxxxxx> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> Cc: Grant Likely <grant.likely@xxxxxxxxxx> Cc: Rob Herring <robh+dt@xxxxxxxxxx> Cc: Vincent Donnefort <vdonnefort@xxxxxxxxx> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-pcf8563.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff -puN drivers/rtc/rtc-pcf8563.c~rtc-pcf8563-save-battery-power drivers/rtc/rtc-pcf8563.c --- a/drivers/rtc/rtc-pcf8563.c~rtc-pcf8563-save-battery-power +++ a/drivers/rtc/rtc-pcf8563.c @@ -42,6 +42,13 @@ #define PCF8563_REG_CLKO 0x0D /* clock out */ #define PCF8563_REG_TMRC 0x0E /* timer control */ +#define PCF8563_TMRC_ENABLE BIT(7) +#define PCF8563_TMRC_4096 0 +#define PCF8563_TMRC_64 1 +#define PCF8563_TMRC_1 2 +#define PCF8563_TMRC_1_60 3 +#define PCF8563_TMRC_MASK 3 + #define PCF8563_REG_TMR 0x0F /* timer */ #define PCF8563_SC_LV 0x80 /* low voltage */ @@ -406,6 +413,7 @@ static int pcf8563_probe(struct i2c_clie { struct pcf8563 *pcf8563; int err; + unsigned char buf; dev_dbg(&client->dev, "%s\n", __func__); @@ -423,6 +431,14 @@ static int pcf8563_probe(struct i2c_clie pcf8563->client = client; device_set_wakeup_capable(&client->dev, 1); + /* Set timer to lowest frequency to save power (ref Haoyu datasheet) */ + buf = PCF8563_TMRC_1_60; + err = pcf8563_write_block_data(client, PCF8563_REG_TMRC, 1, &buf); + if (err < 0) { + dev_err(&client->dev, "%s: write error\n", __func__); + return err; + } + pcf8563->rtc = devm_rtc_device_register(&client->dev, pcf8563_driver.driver.name, &pcf8563_rtc_ops, THIS_MODULE); _ Patches currently in -mm which might be from jan.kardell@xxxxxxxxxx are rtc-pcf8563-remove-leftover-code.patch rtc-pcf8563-fix-write-of-invalid-bits-to-st2-reg.patch rtc-pcf8563-fix-wrong-time-from-read_alarm.patch rtc-pcf8563-handle-consequeces-of-lacking-second-alarm-reg.patch rtc-pcf8563-save-battery-power.patch rtc-pcf8563-clear-expired-alarm-at-boot-time.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html