The patch titled
Subject: mm/slab_common: don't check for duplicate cache names
has been added to the -mm tree. Its filename is
mm-slab_common-dont-check-for-duplicate-cache-names.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-slab_common-dont-check-for-duplicate-cache-names.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slab_common-dont-check-for-duplicate-cache-names.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Subject: mm/slab_common: don't check for duplicate cache names
The SLUB cache merges caches with the same size and alignment and there
was long standing bug with this behavior:
* create the cache named "foo"
* create the cache named "bar" (which is merged with "foo")
* delete the cache named "foo" (but it stays allocated because "bar" uses
it)
* create the cache named "foo" again - it fails because the name "foo" is
already used
That bug was fixed in commit 694617474e33b860 ("slab_common: fix the check
for duplicate slab names") by not warning on duplicate cache names when
the SLUB subsystem is used.
Recently, cache merging was implemented the with SLAB subsystem too, in
12220dea07f1a ("mm/slab: support slab merge")). Therefore we need stop
checking for duplicate names even for the SLAB subsystem. This patch
fixes the bug by removing the check.
Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slab_common.c | 10 ----------
1 file changed, 10 deletions(-)
diff -puN mm/slab_common.c~mm-slab_common-dont-check-for-duplicate-cache-names mm/slab_common.c
--- a/mm/slab_common.c~mm-slab_common-dont-check-for-duplicate-cache-names
+++ a/mm/slab_common.c
@@ -93,16 +93,6 @@ static int kmem_cache_sanity_check(const
s->object_size);
continue;
}
-
-#if !defined(CONFIG_SLUB)
- if (!strcmp(s->name, name)) {
- pr_err("%s (%s): Cache name already exists.\n",
- __func__, name);
- dump_stack();
- s = NULL;
- return -EINVAL;
- }
-#endif
}
WARN_ON(strchr(name, ' ')); /* It confuses parsers */
_
Patches currently in -mm which might be from mpatocka@xxxxxxxxxx are
mm-slab_common-dont-check-for-duplicate-cache-names.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
