The patch titled
Subject: slab: fix for_each_kmem_cache_node()
has been added to the -mm tree. Its filename is
slab-fix-for_each_kmem_cache_node.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/slab-fix-for_each_kmem_cache_node.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/slab-fix-for_each_kmem_cache_node.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Subject: slab: fix for_each_kmem_cache_node()
Fix a bug (discovered with kmemcheck) in for_each_kmem_cache_node(). The
for loop reads the array "node" before verifying that the index is within
the range. This results in kmemcheck warning.
Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slab.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN mm/slab.h~slab-fix-for_each_kmem_cache_node mm/slab.h
--- a/mm/slab.h~slab-fix-for_each_kmem_cache_node
+++ a/mm/slab.h
@@ -338,8 +338,8 @@ static inline struct kmem_cache_node *ge
* a kmem_cache_node structure allocated (which is true for all online nodes)
*/
#define for_each_kmem_cache_node(__s, __node, __n) \
- for (__node = 0; __n = get_node(__s, __node), __node < nr_node_ids; __node++) \
- if (__n)
+ for (__node = 0; __node < nr_node_ids; __node++) \
+ if ((__n = get_node(__s, __node)))
#endif
_
Patches currently in -mm which might be from mpatocka@xxxxxxxxxx are
slab-fix-for_each_kmem_cache_node.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
