+ use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: ntfs: use find_get_page_flags() to mark page accessed as it is no longer marked later on
has been added to the -mm tree.  Its filename is
     use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Anton Altaparmakov <anton@xxxxxxxxxx>
Subject: ntfs: use find_get_page_flags() to mark page accessed as it is no longer marked later on

Mel Gorman's commit 2457aec63745 ("mm: non-atomically mark page accessed
during page cache allocation where possible") removed mark_page_accessed()
calls from NTFS without updating the matching find_lock_page() to
find_get_page_flags(GFP_LOCK | FGP_ACCESSED) thus causing the page to
never be marked accessed.

This patch fixes that.

Signed-off-by: Anton Altaparmakov <anton@xxxxxxxxxx>
Cc: Mel Gorman <mel@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/ntfs/file.c  |    5 +++--
 fs/ntfs/super.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff -puN fs/ntfs/file.c~use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on fs/ntfs/file.c
--- a/fs/ntfs/file.c~use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on
+++ a/fs/ntfs/file.c
@@ -1,7 +1,7 @@
 /*
  * file.c - NTFS kernel file operations.  Part of the Linux-NTFS project.
  *
- * Copyright (c) 2001-2011 Anton Altaparmakov and Tuxera Inc.
+ * Copyright (c) 2001-2014 Anton Altaparmakov and Tuxera Inc.
  *
  * This program/include file is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as published
@@ -410,7 +410,8 @@ static inline int __ntfs_grab_cache_page
 	BUG_ON(!nr_pages);
 	err = nr = 0;
 	do {
-		pages[nr] = find_lock_page(mapping, index);
+		pages[nr] = find_get_page_flags(mapping, index, FGP_LOCK |
+				FGP_ACCESSED);
 		if (!pages[nr]) {
 			if (!*cached_page) {
 				*cached_page = page_cache_alloc(mapping);
diff -puN fs/ntfs/super.c~use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on fs/ntfs/super.c
--- a/fs/ntfs/super.c~use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on
+++ a/fs/ntfs/super.c
@@ -3208,7 +3208,7 @@ static void __exit exit_ntfs_fs(void)
 }
 
 MODULE_AUTHOR("Anton Altaparmakov <anton@xxxxxxxxxx>");
-MODULE_DESCRIPTION("NTFS 1.2/3.x driver - Copyright (c) 2001-2011 Anton Altaparmakov and Tuxera Inc.");
+MODULE_DESCRIPTION("NTFS 1.2/3.x driver - Copyright (c) 2001-2014 Anton Altaparmakov and Tuxera Inc.");
 MODULE_VERSION(NTFS_VERSION);
 MODULE_LICENSE("GPL");
 #ifdef DEBUG
_

Patches currently in -mm which might be from anton@xxxxxxxxxx are

use-find_get_page_flags-to-mark-page-accessed-as-it-is-no-longer-marked-later-on.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux