The patch titled
Subject: checkpatch: relax check for length of git commit IDs
has been added to the -mm tree. Its filename is
checkpatch-relax-check-for-length-of-git-commit-ids.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-relax-check-for-length-of-git-commit-ids.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-relax-check-for-length-of-git-commit-ids.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joe Perches <joe@xxxxxxxxxxx>
Subject: checkpatch: relax check for length of git commit IDs
Checkpatch currently warns if a git commit ID (in the changelog, usually)
is less than 12 characters or more than 16. The "more than 16" is
excessive. Make it "more than 40".
Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN scripts/checkpatch.pl~checkpatch-relax-check-for-length-of-git-commit-ids scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-relax-check-for-length-of-git-commit-ids
+++ a/scripts/checkpatch.pl
@@ -2133,7 +2133,7 @@ sub process {
# Check for improperly formed commit descriptions
if ($in_commit_log &&
$line =~ /\bcommit\s+[0-9a-f]{5,}/i &&
- $line !~ /\b[Cc]ommit [0-9a-f]{12,16} \("/) {
+ $line !~ /\b[Cc]ommit [0-9a-f]{12,40} \("/) {
$line =~ /\b(c)ommit\s+([0-9a-f]{5,})/i;
my $init_char = $1;
my $orig_commit = lc($2);
@@ -2141,7 +2141,7 @@ sub process {
my $desc = 'commit description';
($id, $desc) = git_commit_info($orig_commit, $id, $desc);
ERROR("GIT_COMMIT_ID",
- "Please use 12 to 16 chars for the git commit ID like: '${init_char}ommit $id (\"$desc\")'\n" . $herecurr);
+ "Please use 12 or more chars for the git commit ID like: '${init_char}ommit $id (\"$desc\")'\n" . $herecurr);
}
# Check for added, moved or deleted files
_
Patches currently in -mm which might be from joe@xxxxxxxxxxx are
origin.patch
checkpatch-relax-check-for-length-of-git-commit-ids.patch
mm-utilc-add-kstrimdup.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
