The patch titled Subject: mm, oom: remove unnecessary check for NULL zonelist has been added to the -mm tree. Its filename is mm-oom-remove-unnecessary-check-for-null-zonelist.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-oom-remove-unnecessary-check-for-null-zonelist.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-oom-remove-unnecessary-check-for-null-zonelist.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: David Rientjes <rientjes@xxxxxxxxxx> Subject: mm, oom: remove unnecessary check for NULL zonelist If the pagefault handler is modified to pass a non-NULL zonelist then an unnecessary check for a NULL zonelist in constrained_alloc() can be removed. This also causes panic_on_oom == 1 to not panic the machine when the pagefault is constrained by the mems of current's cpuset. That behavior agrees with the semantics of the sysctl in Documentation/sysctl/vm.txt. Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx> Cc: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Rik van Riel <riel@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/oom_kill.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -puN mm/oom_kill.c~mm-oom-remove-unnecessary-check-for-null-zonelist mm/oom_kill.c --- a/mm/oom_kill.c~mm-oom-remove-unnecessary-check-for-null-zonelist +++ a/mm/oom_kill.c @@ -208,8 +208,6 @@ static enum oom_constraint constrained_a /* Default to all available memory */ *totalpages = totalram_pages + total_swap_pages; - if (!zonelist) - return CONSTRAINT_NONE; /* * Reach here only when __GFP_NOFAIL is used. So, we should avoid * to kill current.We have to random task kill in this case. @@ -696,7 +694,7 @@ void pagefault_out_of_memory(void) zonelist = node_zonelist(first_memory_node, GFP_KERNEL); if (try_set_zonelist_oom(zonelist, GFP_KERNEL)) { - out_of_memory(NULL, 0, 0, NULL, false); + out_of_memory(zonelist, 0, 0, NULL, false); clear_zonelist_oom(zonelist, GFP_KERNEL); } } _ Patches currently in -mm which might be from rientjes@xxxxxxxxxx are origin.patch x86-numa-setup_node_data-drop-dead-code-and-rename-function.patch x86-numa-setup_node_data-drop-dead-code-and-rename-function-v2.patch score-ptrace-remove-the-macros-which-not-be-used-currently.patch mm-slabc-add-__init-to-init_lock_keys.patch slab-common-add-functions-for-kmem_cache_node-access.patch slab-common-add-functions-for-kmem_cache_node-access-fix.patch slub-use-new-node-functions.patch slub-use-new-node-functions-fix.patch slab-use-get_node-and-kmem_cache_node-functions.patch slab-use-get_node-and-kmem_cache_node-functions-fix.patch slab-use-get_node-and-kmem_cache_node-functions-fix-2.patch mm-slabh-wrap-the-whole-file-with-guarding-macro.patch mm-slub-mark-resiliency_test-as-init-text.patch mm-slub-slub_debug=n-use-the-same-alloc-free-hooks-as-for-slub_debug=y.patch slab-add-unlikely-macro-to-help-compiler.patch slab-move-up-code-to-get-kmem_cache_node-in-free_block.patch slab-defer-slab_destroy-in-free_block.patch slab-defer-slab_destroy-in-free_block-v4.patch slab-factor-out-initialization-of-arracy-cache.patch slab-introduce-alien_cache.patch slab-use-the-lock-on-alien_cache-instead-of-the-lock-on-array_cache.patch slab-destroy-a-slab-without-holding-any-alien-cache-lock.patch slab-remove-a-useless-lockdep-annotation.patch slab-remove-bad_alien_magic.patch slab-change-int-to-size_t-for-representing-allocation-size.patch slub-reduce-duplicate-creation-on-the-first-object.patch mm-move-slab-related-stuff-from-utilc-to-slab_commonc.patch mm-trivial-comment-cleanup-in-slabc.patch mm-slub-fix-some-indenting-in-cmpxchg_double_slab.patch slab-fix-the-alias-countvia-sysfs-of-slab-cache.patch mm-readaheadc-remove-unused-file_ra_state-from-count_history_pages.patch mm-memory_hotplugc-add-__meminit-to-grow_zone_span-grow_pgdat_span.patch mm-page_allocc-unexport-alloc_pages_exact_nid.patch mm-page_alloc-simplify-drain_zone_pages-by-using-min.patch mm-mem-hotplug-replace-simple_strtoull-with-kstrtoull.patch mm-vmallocc-add-a-schedule-point-to-vmalloc.patch mm-vmallocc-add-a-schedule-point-to-vmalloc-fix.patch mm-vmalloc-constify-allocation-mask.patch mmhugetlb-make-unmap_ref_private-return-void.patch mmhugetlb-simplify-error-handling-in-hugetlb_cow.patch mm-hugetlb-generalize-writes-to-nr_hugepages.patch mm-hugetlb-generalize-writes-to-nr_hugepages-fix.patch mm-hugetlb-remove-hugetlb_zero-and-hugetlb_infinity.patch mm-make-copy_pte_range-static-again.patch mm-thp-only-collapse-hugepages-to-nodes-with-affinity-for-zone_reclaim_mode.patch mm-writeback-prevent-race-when-calculating-dirty-limits.patch slub-remove-kmemcg-id-from-create_unique_id.patch mm-oom-ensure-memoryless-node-zonelist-always-includes-zones.patch mm-oom-ensure-memoryless-node-zonelist-always-includes-zones-fix.patch mm-oom-remove-unnecessary-check-for-null-zonelist.patch mm-oom-rename-zonelist-locking-functions.patch mm-thp-restructure-thp-avoidance-of-light-synchronous-migration.patch mm-fix-potential-infinite-loop-in-dissolve_free_huge_pages.patch mm-fix-potential-infinite-loop-in-dissolve_free_huge_pages-fix.patch mm-oom-remove-unnecessary-exit_state-check.patch mm-close-race-between-do_fault_around-and-fault_around_bytes_set.patch mm-mark-fault_around_bytes-__read_mostly.patch mm-hugetlb-take-refcount-under-page-table-lock-in-follow_huge_pmd.patch mm-hugetlb-use-get_page_unless_zero-in-hugetlb_fault.patch mm-hugetlb-add-migration-entry-check-in-hugetlb_change_protection.patch include-kernelh-rewrite-min3-max3-and-clamp-using-min-and-max.patch lib-add-size-unit-t-p-e-to-memparse.patch mm-utilc-add-kstrimdup.patch fs-proc-kcorec-use-page_align-instead-of-alignpage_size.patch fork-exec-cleanup-mm-initialization.patch fork-reset-mm-pinned_vm.patch fork-copy-mms-vm-usage-counters-under-mmap_sem.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html