The patch titled
Subject: checkpatch: warn on missing spaces in broken up quoted
has been added to the -mm tree. Its filename is
checkpatch-warn-on-missing-spaces-in-broken-up-quoted.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-warn-on-missing-spaces-in-broken-up-quoted.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-warn-on-missing-spaces-in-broken-up-quoted.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: checkpatch: warn on missing spaces in broken up quoted
Checkpatch already complains when people break up quoted strings but it's
still pretty common. One mistake that people often make is they leave out
the space character between the two strings.
This check adds around 450 new warnings and has a low rate of false
positives.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
Acked-by: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-warn-on-missing-spaces-in-broken-up-quoted scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-warn-on-missing-spaces-in-broken-up-quoted
+++ a/scripts/checkpatch.pl
@@ -2361,6 +2361,12 @@ sub process {
"quoted string split across lines\n" . $hereprev);
}
+# check for missing a space in a string concatination
+ if ($prevrawline =~ /[^\\]\w"$/ && $rawline =~ /^\+[\t ]+"\w/) {
+ WARN('MISSING_SPACE',
+ "break quoted strings at a space character\n" . $hereprev);
+ }
+
# check for spaces before a quoted newline
if ($rawline =~ /^.*\".*\s\\n/) {
if (WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
_
Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are
mm-slub-fix-some-indenting-in-cmpxchg_double_slab.patch
makefile-tell-gcc-optimizer-to-never-introduce-new-data-races.patch
checkpatch-attempt-to-find-unnecessary-out-of-memory-messages.patch
checkpatch-add-an-index-variable-for-fixed-lines.patch
checkpatch-add-ability-to-insert-and-delete-lines-to-patch-file.patch
checkpatch-warn-on-missing-spaces-in-broken-up-quoted.patch
rtc-rtc-pcf8563-add-alarm-support-fix.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
