The patch titled Subject: lib: bitmap: simplify bitmap_parselist has been added to the -mm tree. Its filename is lib-bitmap-simplify-bitmap_parselist.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/lib-bitmap-simplify-bitmap_parselist.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/lib-bitmap-simplify-bitmap_parselist.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> Subject: lib: bitmap: simplify bitmap_parselist We want len to be the index of the first '\n', or the length of the string if there is no newline. This is a good example of the usefulness of strchrnul(). Use that instead, thus eliminating a branch and a call to strlen(). Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- lib/bitmap.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff -puN lib/bitmap.c~lib-bitmap-simplify-bitmap_parselist lib/bitmap.c --- a/lib/bitmap.c~lib-bitmap-simplify-bitmap_parselist +++ a/lib/bitmap.c @@ -665,13 +665,8 @@ static int __bitmap_parselist(const char int bitmap_parselist(const char *bp, unsigned long *maskp, int nmaskbits) { - char *nl = strchr(bp, '\n'); - int len; - - if (nl) - len = nl - bp; - else - len = strlen(bp); + char *nl = strchrnul(bp, '\n'); + int len = nl - bp; return __bitmap_parselist(bp, len, 0, maskp, nmaskbits); } _ Patches currently in -mm which might be from linux@xxxxxxxxxxxxxxxxxx are lib-list_sort_test-return-enomem-when-allocation-fails.patch lib-list_sort_test-add-extra-corruption-check.patch lib-list_sort_test-simplify-and-harden-cleanup.patch lib-list_sortc-limit-number-of-unused-cmp-callbacks.patch lib-list_sortc-convert-to-pr_foo.patch lib-list_sortc-convert-to-pr_foo-fix.patch lib-bitmap-make-nbits-parameter-of-bitmap_empty-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_full-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_equal-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_complement-unsigned.patch lib-bitmap-remove-unnecessary-mask-from-bitmap_complement.patch lib-bitmap-make-nbits-parameter-of-bitmap_andorxorandnot-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_intersects-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_subset-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned.patch lib-bitmap-make-the-start-index-of-bitmap_set-unsigned.patch lib-bitmap-make-the-start-index-of-bitmap_clear-unsigned.patch lib-bitmap-simplify-bitmap_parselist.patch lib-bitmap-fix-typo-in-kerneldoc-for-bitmap_pos_to_ord.patch lib-bitmap-change-parameter-of-bitmap__region-to-unsigned.patch lib-bitmap-micro-optimize-bitmap_allocate_region.patch lib-bitmap-add-missing-mask-in-bitmap_shift_right.patch lib-bitmap-add-missing-mask-in-bitmap_and.patch lib-bitmap-add-missing-mask-in-bitmap_andnot.patch checkpatchpl-also-suggest-else-if-when-if-follows-brace.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html