The patch titled Subject: lib: bitmap: make nbits parameter of bitmap_weight unsigned has been added to the -mm tree. Its filename is lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> Subject: lib: bitmap: make nbits parameter of bitmap_weight unsigned The compiler can generate slightly smaller and simpler code when it knows that "nbits" is non-negative. Since no-one passes a negative bit-count, this shouldn't affect the semantics. I didn't change the return type, since that might change the semantics of some expression containing a call to bitmap_weight(). Certainly an int is capable of holding the result. Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/bitmap.h | 4 ++-- lib/bitmap.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff -puN include/linux/bitmap.h~lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned include/linux/bitmap.h --- a/include/linux/bitmap.h~lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned +++ a/include/linux/bitmap.h @@ -110,7 +110,7 @@ extern int __bitmap_intersects(const uns const unsigned long *bitmap2, unsigned int nbits); extern int __bitmap_subset(const unsigned long *bitmap1, const unsigned long *bitmap2, unsigned int nbits); -extern int __bitmap_weight(const unsigned long *bitmap, int bits); +extern int __bitmap_weight(const unsigned long *bitmap, unsigned int nbits); extern void bitmap_set(unsigned long *map, int i, int len); extern void bitmap_clear(unsigned long *map, int start, int nr); @@ -273,7 +273,7 @@ static inline int bitmap_full(const unsi return __bitmap_full(src, nbits); } -static inline int bitmap_weight(const unsigned long *src, int nbits) +static inline int bitmap_weight(const unsigned long *src, unsigned int nbits) { if (small_const_nbits(nbits)) return hweight_long(*src & BITMAP_LAST_WORD_MASK(nbits)); diff -puN lib/bitmap.c~lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned lib/bitmap.c --- a/lib/bitmap.c~lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned +++ a/lib/bitmap.c @@ -259,9 +259,10 @@ int __bitmap_subset(const unsigned long } EXPORT_SYMBOL(__bitmap_subset); -int __bitmap_weight(const unsigned long *bitmap, int bits) +int __bitmap_weight(const unsigned long *bitmap, unsigned int bits) { - int k, w = 0, lim = bits/BITS_PER_LONG; + unsigned int k, lim = bits/BITS_PER_LONG; + int w = 0; for (k = 0; k < lim; k++) w += hweight_long(bitmap[k]); _ Patches currently in -mm which might be from linux@xxxxxxxxxxxxxxxxxx are lib-list_sort_test-return-enomem-when-allocation-fails.patch lib-list_sort_test-add-extra-corruption-check.patch lib-list_sort_test-simplify-and-harden-cleanup.patch lib-list_sortc-limit-number-of-unused-cmp-callbacks.patch lib-list_sortc-convert-to-pr_foo.patch lib-list_sortc-convert-to-pr_foo-fix.patch lib-bitmap-make-nbits-parameter-of-bitmap_empty-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_full-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_equal-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_complement-unsigned.patch lib-bitmap-remove-unnecessary-mask-from-bitmap_complement.patch lib-bitmap-make-nbits-parameter-of-bitmap_andorxorandnot-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_intersects-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_subset-unsigned.patch lib-bitmap-make-nbits-parameter-of-bitmap_weight-unsigned.patch lib-bitmap-make-the-start-index-of-bitmap_set-unsigned.patch lib-bitmap-make-the-start-index-of-bitmap_clear-unsigned.patch lib-bitmap-simplify-bitmap_parselist.patch lib-bitmap-fix-typo-in-kerneldoc-for-bitmap_pos_to_ord.patch lib-bitmap-change-parameter-of-bitmap__region-to-unsigned.patch lib-bitmap-micro-optimize-bitmap_allocate_region.patch lib-bitmap-add-missing-mask-in-bitmap_shift_right.patch lib-bitmap-add-missing-mask-in-bitmap_and.patch lib-bitmap-add-missing-mask-in-bitmap_andnot.patch checkpatchpl-also-suggest-else-if-when-if-follows-brace.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html