The patch titled Remove superfluous call to call to cdev_del() has been added to the -mm tree. Its filename is remove-superfluous-call-to-call-to-cdev_del.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: Remove superfluous call to call to cdev_del() From: Rolf Eike Beer <eike-kernel@xxxxxxxxx> If cdev_add() fails there is no good reason to call cdev_del(). Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx> Cc: Alessandro Zummo <alessandro.zummo@xxxxxxxxxxxx> Cc: Dmitry Torokhov <dtor@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/rtc/rtc-dev.c | 1 - 1 files changed, 1 deletion(-) diff -puN drivers/rtc/rtc-dev.c~remove-superfluous-call-to-call-to-cdev_del drivers/rtc/rtc-dev.c --- a/drivers/rtc/rtc-dev.c~remove-superfluous-call-to-call-to-cdev_del +++ a/drivers/rtc/rtc-dev.c @@ -406,7 +406,6 @@ static int rtc_dev_add_device(struct cla rtc->char_dev.owner = rtc->owner; if (cdev_add(&rtc->char_dev, MKDEV(MAJOR(rtc_devt), rtc->id), 1)) { - cdev_del(&rtc->char_dev); dev_err(class_dev->dev, "failed to add char device %d:%d\n", MAJOR(rtc_devt), rtc->id); _ Patches currently in -mm which might be from eike-kernel@xxxxxxxxx are add-kerneldocs-for-some-functions-in-mm-memoryc.patch use-bug_onfoo-instead-of-if-foo-bug-in-include-asm-i386-dma-mappingh.patch include-documentation-for-functions-in-drivers-base-classc.patch fix-parameter-names-in-drivers-base-classc.patch fix-kerneldoc-comments-in-kernel-timerc.patch fix-kerneldoc-comments-in-kernel-timerc-fix.patch move-valid_dma_direction-from-x86_64-to-generic-code.patch move-valid_dma_direction-from-x86_64-to-generic-code-fix.patch use-valid_dma_direction-in-include-asm-i386-dma-mappingh.patch cdev-documentation-was-drop-second-arg-of-unregister_chrdev.patch return-better-error-codes-if-drivers-char-rawc-module-init-fails.patch remove-superfluous-call-to-call-to-cdev_del.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html