Subject: + mm-page-writebackc-remove-outdated-comment.patch added to -mm tree To: nasa4836@xxxxxxxxx,hannes@xxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 02 Jun 2014 13:53:16 -0700 The patch titled Subject: mm/page-writeback.c: remove outdated comment has been added to the -mm tree. Its filename is mm-page-writebackc-remove-outdated-comment.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-page-writebackc-remove-outdated-comment.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-page-writebackc-remove-outdated-comment.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jianyu Zhan <nasa4836@xxxxxxxxx> Subject: mm/page-writeback.c: remove outdated comment There is an orphaned prehistoric comment , which used to be against get_dirty_limits(), the dawn of global_dirtyable_memory(). Back then, the implementation of get_dirty_limits() is complicated and full of magic numbers, so this comment is necessary. But we now use the clear and neat global_dirtyable_memory(), which renders this comment ambiguous and useless. Remove it. Signed-off-by: Jianyu Zhan <nasa4836@xxxxxxxxx> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/page-writeback.c | 18 ------------------ 1 file changed, 18 deletions(-) diff -puN mm/page-writeback.c~mm-page-writebackc-remove-outdated-comment mm/page-writeback.c --- a/mm/page-writeback.c~mm-page-writebackc-remove-outdated-comment +++ a/mm/page-writeback.c @@ -156,24 +156,6 @@ static unsigned long writeout_period_tim #define VM_COMPLETIONS_PERIOD_LEN (3*HZ) /* - * Work out the current dirty-memory clamping and background writeout - * thresholds. - * - * The main aim here is to lower them aggressively if there is a lot of mapped - * memory around. To avoid stressing page reclaim with lots of unreclaimable - * pages. It is better to clamp down on writers than to start swapping, and - * performing lots of scanning. - * - * We only allow 1/2 of the currently-unmapped memory to be dirtied. - * - * We don't permit the clamping level to fall below 5% - that is getting rather - * excessive. - * - * We make sure that the background writeout level is below the adjusted - * clamping level. - */ - -/* * In a memory zone, there is a certain amount of pages we consider * available for the page cache, which is essentially the number of * free and reclaimable pages, minus some zone reserves to protect _ Patches currently in -mm which might be from nasa4836@xxxxxxxxx are mm-swapc-clean-up-lru_cache_add-functions.patch mm-swapc-introduce-put_refcounted_compound_page-helpers-for-spliting-put_compound_page.patch mm-swapc-split-put_compound_page-function.patch mm-introdule-compound_head_by_tail.patch mm-add-comment-for-__mod_zone_page_stat.patch mm-add-comment-for-__mod_zone_page_stat-checkpatch-fixes.patch mm-fold-mlocked_vma_newpage-into-its-only-call-site.patch mm-fold-mlocked_vma_newpage-into-its-only-call-site-checkpatch-fixes.patch mm-hugetlb-move-the-error-handle-logic-out-of-normal-code-path.patch mm-vmscanc-use-div_round_up-for-calculation-of-zones-balance_gap-and-correct-comments.patch mm-page-writebackc-remove-outdated-comment.patch linux-next.patch mm-memcontrol-clean-up-memcg-zoneinfo-lookup.patch mm-memcontrol-remove-unnecessary-memcg-argument-from-soft-limit-functions.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html