Subject: + sysctl-allow-for-strict-write-position-handling-fix-3.patch added to -mm tree
To: keescook@xxxxxxxxxxxx,akpm@xxxxxxxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 07 May 2014 12:23:29 -0700
The patch titled
Subject: sysctl: flip file position warning to pr_warn_once
has been added to the -mm tree. Its filename is
sysctl-allow-for-strict-write-position-handling-fix-3.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/sysctl-allow-for-strict-write-position-handling-fix-3.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/sysctl-allow-for-strict-write-position-handling-fix-3.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Kees Cook <keescook@xxxxxxxxxxxx>
Subject: sysctl: flip file position warning to pr_warn_once
To avoid dmesg flooding, use pr_warn_once instead of pr_warn.
Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
Suggested-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/sysctl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff -puN kernel/sysctl.c~sysctl-allow-for-strict-write-position-handling-fix-3 kernel/sysctl.c
--- a/kernel/sysctl.c~sysctl-allow-for-strict-write-position-handling-fix-3
+++ a/kernel/sysctl.c
@@ -1783,10 +1783,9 @@ static int _proc_do_string(char *data, i
static void warn_sysctl_write(struct ctl_table *table)
{
- pr_warn("write to %s by %s used a non-zero file position!\n",
- table->procname, current->comm);
- pr_warn("This will not be supported in the future.\n");
- pr_warn("To silence warning, set kernel.sysctl_writes_strict = -1\n");
+ pr_warn_once("%s wrote to %s when file position was not 0!\n"
+ "This will not be supported in the future. To silence this\n"
+ "warning, set kernel.sysctl_writes_strict = -1\n",
}
/**
_
Patches currently in -mm which might be from keescook@xxxxxxxxxxxx are
origin.patch
lib-vsprintf-add-%pt-format-specifier.patch
binfmt_elfc-use-get_random_int-to-fix-entropy-depleting.patch
ptrace-fix-fork-event-messages-across-pid-namespaces.patch
sysctl-clean-up-char-buffer-arguments.patch
sysctl-refactor-sysctl-string-writing-logic.patch
sysctl-allow-for-strict-write-position-handling.patch
sysctl-allow-for-strict-write-position-handling-fix-2.patch
sysctl-allow-for-strict-write-position-handling-fix.patch
sysctl-allow-for-strict-write-position-handling-fix-3.patch
tools-testing-selftests-sysctl-validate-sysctl_writes_strict.patch
tools-testing-selftests-sysctl-validate-sysctl_writes_strict-fix.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
