+ agp-info-leak-in-agpioc_info_wrap.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Subject: + agp-info-leak-in-agpioc_info_wrap.patch added to -mm tree
To: dan.carpenter@xxxxxxxxxx,airlied@xxxxxxxx,daniel.vetter@xxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 05 May 2014 14:01:38 -0700


The patch titled
     Subject: agp: info leak in agpioc_info_wrap()
has been added to the -mm tree.  Its filename is
     agp-info-leak-in-agpioc_info_wrap.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/agp-info-leak-in-agpioc_info_wrap.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/agp-info-leak-in-agpioc_info_wrap.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: agp: info leak in agpioc_info_wrap()

On 64 bit systems the agp_info struct has a 4 byte hole between ->agp_mode
and ->aper_base.  We need to clear it to avoid disclosing stack
information to userspace.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Cc: David Airlie <airlied@xxxxxxxx>
Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/char/agp/frontend.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/char/agp/frontend.c~agp-info-leak-in-agpioc_info_wrap drivers/char/agp/frontend.c
--- a/drivers/char/agp/frontend.c~agp-info-leak-in-agpioc_info_wrap
+++ a/drivers/char/agp/frontend.c
@@ -730,6 +730,7 @@ static int agpioc_info_wrap(struct agp_f
 
 	agp_copy_info(agp_bridge, &kerninfo);
 
+	memset(&userinfo, 0, sizeof(userinfo));
 	userinfo.version.major = kerninfo.version.major;
 	userinfo.version.minor = kerninfo.version.minor;
 	userinfo.bridge_id = kerninfo.device->vendor |
_

Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are

agp-info-leak-in-agpioc_info_wrap.patch
lib-stringc-use-the-name-c-string-in-comments.patch
linux-next.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux