[folded-merged] kobject-dont-block-for-each-kobject_uevent-v2.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Subject: [folded-merged] kobject-dont-block-for-each-kobject_uevent-v2.patch removed from -mm tree
To: vdavydov@xxxxxxxxxxxxx,cl@xxxxxxxxx,greg@xxxxxxxxx,penberg@xxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Thu, 03 Apr 2014 14:08:49 -0700


The patch titled
     Subject: kobject-dont-block-for-each-kobject_uevent-v2
has been removed from the -mm tree.  Its filename was
     kobject-dont-block-for-each-kobject_uevent-v2.patch

This patch was dropped because it was folded into kobject-dont-block-for-each-kobject_uevent.patch

------------------------------------------------------
From: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Subject: kobject-dont-block-for-each-kobject_uevent-v2

I missed that call_usermodehelper_exec() calls cleanup not only on
success, but also on failure resulting in a bunch of double frees at early
boot when khelper hasn't been initialized yet :-(

Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 lib/kobject_uevent.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -puN lib/kobject_uevent.c~kobject-dont-block-for-each-kobject_uevent-v2 lib/kobject_uevent.c
--- a/lib/kobject_uevent.c~kobject-dont-block-for-each-kobject_uevent-v2
+++ a/lib/kobject_uevent.c
@@ -342,10 +342,10 @@ int kobject_uevent_env(struct kobject *k
 		info = call_usermodehelper_setup(env->argv[0], env->argv,
 						 env->envp, GFP_KERNEL,
 						 NULL, cleanup_uevent_env, env);
-		if (info)
+		if (info) {
 			retval = call_usermodehelper_exec(info, UMH_NO_WAIT);
-		if (!retval)
-			env = NULL;	/* will be freed by cleanup_uevent_env */
+			env = NULL;	/* freed by cleanup_uevent_env */
+		}
 	}
 
 exit:
_

Patches currently in -mm which might be from vdavydov@xxxxxxxxxxxxx are

origin.patch
mm-vmscan-respect-numa-policy-mask-when-shrinking-slab-on-direct-reclaim.patch
mm-vmscan-move-call-to-shrink_slab-to-shrink_zones.patch
mm-vmscan-remove-shrink_control-arg-from-do_try_to_free_pages.patch
mm-vmscan-shrink_slab-rename-max_pass-freeable.patch
kobject-dont-block-for-each-kobject_uevent.patch
slub-do-not-drop-slab_mutex-for-sysfs_slab_add.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux