Subject: + drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq.patch added to -mm tree
To: Adam.Thomson.Opensource@xxxxxxxxxxx,a.zummo@xxxxxxxxxxxx,dmitry.torokhov@xxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Tue, 01 Apr 2014 15:51:16 -0700
The patch titled
Subject: drivers/rtc/rtc-da9055.c: remove use of regmap_irq_get_virq()
has been added to the -mm tree. Its filename is
drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
Subject: drivers/rtc/rtc-da9055.c: remove use of regmap_irq_get_virq()
Using platform_get_irq_byname() to retrieve the IRQ number returns the
VIRQ number rather than the local IRQ number for the device. Passing that
value then into regmap_irq_get_virq() causes a failure because the
function is expecting the local IRQ number (e.g. 0, 1, 2, 3, etc).
This patch removes use of regmap_irq_get_virq() to prevent this failure
from happening
Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-da9055.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/rtc/rtc-da9055.c~drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq drivers/rtc/rtc-da9055.c
--- a/drivers/rtc/rtc-da9055.c~drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq
+++ a/drivers/rtc/rtc-da9055.c
@@ -302,7 +302,9 @@ static int da9055_rtc_probe(struct platf
}
alm_irq = platform_get_irq_byname(pdev, "ALM");
- alm_irq = regmap_irq_get_virq(rtc->da9055->irq_data, alm_irq);
+ if (alm_irq < 0)
+ return alm_irq;
+
ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL,
da9055_rtc_alm_irq,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
_
Patches currently in -mm which might be from Adam.Thomson.Opensource@xxxxxxxxxxx are
drivers-rtc-rtc-da9055c-remove-use-of-regmap_irq_get_virq.patch
input-da9055_onkey-remove-use-of-regmap_irq_get_virq.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
