Subject: + ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed.patch added to -mm tree
To: xuejiufei@xxxxxxxxxx,jlbec@xxxxxxxxxxxx,mfasheh@xxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 26 Mar 2014 14:58:43 -0700
The patch titled
Subject: ocfs2: __ocfs2_mknod_locked should return error when ocfs2_create_new_inode_locks() failed
has been added to the -mm tree. Its filename is
ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Xue jiufei <xuejiufei@xxxxxxxxxx>
Subject: ocfs2: __ocfs2_mknod_locked should return error when ocfs2_create_new_inode_locks() failed
When ocfs2_create_new_inode_locks() return error, inode open lock may not
be obtainted for this inode. So other nodes can remove this file and free
dinode when inode still remain in memory on this node, which is not
correct and may trigger BUG. So __ocfs2_mknod_locked should return error
when ocfs2_create_new_inode_locks() failed.
Node_1 Node_2
create fileA, call ocfs2_mknod()
-> ocfs2_get_init_inode(), allocate inodeA
-> ocfs2_claim_new_inode(), claim dinode(dinodeA)
-> call ocfs2_create_new_inode_locks(),
create open lock failed, return error
-> __ocfs2_mknod_locked return success
unlink fileA
try open lock succeed,
and free dinodeA
create another file, call ocfs2_mknod()
-> ocfs2_get_init_inode(), allocate inodeB
-> ocfs2_claim_new_inode(), as Node_2 had freed dinodeA,
so claim dinodeA and update generation for dinodeA
call __ocfs2_drop_dl_inodes()->ocfs2_delete_inode()
to free inodeA, and finally triggers BUG
on(inode->i_generation != le32_to_cpu(fe->i_generation))
in function ocfs2_inode_lock_update().
Signed-off-by: joyce.xue <xuejiufei@xxxxxxxxxx>
Cc: Mark Fasheh <mfasheh@xxxxxxxx>
Cc: Joel Becker <jlbec@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/ocfs2/namei.c | 3 ---
1 file changed, 3 deletions(-)
diff -puN fs/ocfs2/namei.c~ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed fs/ocfs2/namei.c
--- a/fs/ocfs2/namei.c~ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed
+++ a/fs/ocfs2/namei.c
@@ -580,9 +580,6 @@ static int __ocfs2_mknod_locked(struct i
oi->i_sync_tid = handle->h_transaction->t_tid;
oi->i_datasync_tid = handle->h_transaction->t_tid;
- status = 0; /* error in ocfs2_create_new_inode_locks is not
- * critical */
-
leave:
if (status < 0) {
if (*new_fe_bh) {
_
Patches currently in -mm which might be from xuejiufei@xxxxxxxxxx are
ocfs2-remove-unused-variable-uuid_net_key-in-ocfs2_initialize_super.patch
ocfs2-__ocfs2_mknod_locked-should-return-error-when-ocfs2_create_new_inode_locks-failed.patch
ocfs2-do-not-return-dlm_migrate_response_mastery_ref-to-avoid-endlessloop-during-umount.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
