Subject: + samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips.patch added to -mm tree
To: markos.chandras@xxxxxxxxxx,paul.gortmaker@xxxxxxxxxxxxx,ralf@xxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 12 Mar 2014 12:59:37 -0700
The patch titled
Subject: samples/seccomp/Makefile: do not build tests if cross-compiling for MIPS
has been added to the -mm tree. Its filename is
samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Markos Chandras <markos.chandras@xxxxxxxxxx>
Subject: samples/seccomp/Makefile: do not build tests if cross-compiling for MIPS
The Makefile is designed to use the host toolchain so it may be unsafe to
build the tests if the kernel has been configured and built for another
architecture. This fixes a build problem when the kernel has been
configured and built for the MIPS architecture but the host is not MIPS
(cross-compiled). The MIPS syscalls are only defined if one of the
following is true:
1) _MIPS_SIM == _MIPS_SIM_ABI64
2) _MIPS_SIM == _MIPS_SIM_ABI32
3) _MIPS_SIM == _MIPS_SIM_NABI32
Of course, none of these make sense on a non-MIPS toolchain and the
following build problem occurs when building on a non-MIPS host.
linux/usr/include/linux/kexec.h:50:
userspace cannot reference function or variable defined in the kernel
samples/seccomp/bpf-direct.c: In function `emulator':
samples/seccomp/bpf-direct.c:76:17: error:
`__NR_write' undeclared (first use in this function)
Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
Reported-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
samples/seccomp/Makefile | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff -puN samples/seccomp/Makefile~samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips samples/seccomp/Makefile
--- a/samples/seccomp/Makefile~samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips
+++ a/samples/seccomp/Makefile
@@ -18,8 +18,8 @@ HOSTCFLAGS_bpf-direct.o += -idirafter $(
bpf-direct-objs := bpf-direct.o
# Try to match the kernel target.
-ifndef CONFIG_64BIT
ifndef CROSS_COMPILE
+ifndef CONFIG_64BIT
# s390 has -m31 flag to build 31 bit binaries
ifndef CONFIG_S390
@@ -36,7 +36,13 @@ HOSTLOADLIBES_bpf-direct += $(MFLAG)
HOSTLOADLIBES_bpf-fancy += $(MFLAG)
HOSTLOADLIBES_dropper += $(MFLAG)
endif
-endif
-
-# Tell kbuild to always build the programs
always := $(hostprogs-y)
+else
+# MIPS system calls are defined based on the -mabi that is passed
+# to the toolchain which may or may not be a valid option
+# for the host toolchain. So disable tests if target architecture
+# is MIPS but the host isn't.
+ifndef CONFIG_MIPS
+always := $(hostprogs-y)
+endif
+endif
_
Patches currently in -mm which might be from markos.chandras@xxxxxxxxxx are
samples-seccomp-makefile-do-not-build-tests-if-cross-compiling-for-mips.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
