Subject: + checkpatch-fix-spurious-vendor-compatible-warnings.patch added to -mm tree To: florian.vaussard@xxxxxxx,joe@xxxxxxxxxxx,robh@xxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 10 Mar 2014 12:09:24 -0700 The patch titled Subject: checkpatch: fix spurious vendor compatible warnings has been added to the -mm tree. Its filename is checkpatch-fix-spurious-vendor-compatible-warnings.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-fix-spurious-vendor-compatible-warnings.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-fix-spurious-vendor-compatible-warnings.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Florian Vaussard <florian.vaussard@xxxxxxx> Subject: checkpatch: fix spurious vendor compatible warnings With a compatible string like compatible = "foo"; checkpatch will currently try to find "foo" in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case. Skip the vendor test if the compatible is not like compatible = "vendor,something"; Signed-off-by: Florian Vaussard <florian.vaussard@xxxxxxx> Cc: Joe Perches <joe@xxxxxxxxxxx> Acked-by: Rob Herring <robh@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN scripts/checkpatch.pl~checkpatch-fix-spurious-vendor-compatible-warnings scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatch-fix-spurious-vendor-compatible-warnings +++ a/scripts/checkpatch.pl @@ -2081,10 +2081,10 @@ sub process { "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr); } - my $vendor = $compat; my $vendor_path = $dt_path . "vendor-prefixes.txt"; next if (! -f $vendor_path); - $vendor =~ s/^([a-zA-Z0-9\-]+)\,.*/$1/; + next if $compat !~ /^([a-zA-Z0-9\-]+)\,/; + my $vendor = $1; `grep -Eq "$vendor" $vendor_path`; if ( $? >> 8 ) { WARN("UNDOCUMENTED_DT_STRING", _ Patches currently in -mm which might be from florian.vaussard@xxxxxxx are checkpatch-check-vendor-compatible-with-dashes.patch checkpatch-fix-spurious-vendor-compatible-warnings.patch checkpatch-check-compatible-strings-in-c-and-h-too.patch checkpatch-improve-the-compatible-vendor-match.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html