Subject: + mm-per-thread-vma-caching-fix-3.patch added to -mm tree To: akpm@xxxxxxxxxxxxxxxxxxxx,davidlohr@xxxxxx,riel@xxxxxxxxxx,torvalds@xxxxxxxxxxxxxxxxxxxx,walken@xxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Thu, 06 Mar 2014 14:56:41 -0800 The patch titled Subject: mm-per-thread-vma-caching-fix-3 has been added to the -mm tree. Its filename is mm-per-thread-vma-caching-fix-3.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-per-thread-vma-caching-fix-3.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-per-thread-vma-caching-fix-3.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: mm-per-thread-vma-caching-fix-3 Attempt to untangle header files. Prior to this patch: mm.h does not require sched.h sched.h does not require mm.h sched.h requires vmacache.h vmacache.h requires mm.h After this patch: mm.h still does not require sched.h sched.h still does not require mm.h sched.h does not require vmacache.h mm.h does not require vmacache.h vmacache.h requires (and includes) mm.h vmacache.h requires (and includes) sched.h To do all this, the three "#define VMACACHE_foo" lines were moved to sched.h. The inclusions of sched.h and mm.h into vmacache.h are actually unrequired because the .c files include mm.h and sched.h directly, but I put them in there for cargo-cult reasons. vmacache_flush() no longer needs to be implemented in cpp - make it so. Cc: Davidlohr Bueso <davidlohr@xxxxxx> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Cc: Michel Lespinasse <walken@xxxxxxxxxx> Cc: Rik van Riel <riel@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/unicore32/include/asm/mmu_context.h | 2 ++ fs/exec.c | 1 + fs/proc/task_mmu.c | 1 + include/linux/sched.h | 5 ++++- include/linux/vmacache.h | 12 +++++------- kernel/debug/debug_core.c | 1 + kernel/fork.c | 2 ++ mm/mmap.c | 1 + mm/nommu.c | 1 + mm/vmacache.c | 1 + 10 files changed, 19 insertions(+), 8 deletions(-) diff -puN arch/unicore32/include/asm/mmu_context.h~mm-per-thread-vma-caching-fix-3 arch/unicore32/include/asm/mmu_context.h --- a/arch/unicore32/include/asm/mmu_context.h~mm-per-thread-vma-caching-fix-3 +++ a/arch/unicore32/include/asm/mmu_context.h @@ -14,6 +14,8 @@ #include <linux/compiler.h> #include <linux/sched.h> +#include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/io.h> #include <asm/cacheflush.h> diff -puN fs/exec.c~mm-per-thread-vma-caching-fix-3 fs/exec.c --- a/fs/exec.c~mm-per-thread-vma-caching-fix-3 +++ a/fs/exec.c @@ -26,6 +26,7 @@ #include <linux/file.h> #include <linux/fdtable.h> #include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/stat.h> #include <linux/fcntl.h> #include <linux/swap.h> diff -puN fs/proc/task_mmu.c~mm-per-thread-vma-caching-fix-3 fs/proc/task_mmu.c --- a/fs/proc/task_mmu.c~mm-per-thread-vma-caching-fix-3 +++ a/fs/proc/task_mmu.c @@ -1,4 +1,5 @@ #include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/hugetlb.h> #include <linux/huge_mm.h> #include <linux/mount.h> diff -puN include/linux/mm_types.h~mm-per-thread-vma-caching-fix-3 include/linux/mm_types.h diff -puN include/linux/sched.h~mm-per-thread-vma-caching-fix-3 include/linux/sched.h --- a/include/linux/sched.h~mm-per-thread-vma-caching-fix-3 +++ a/include/linux/sched.h @@ -23,7 +23,6 @@ struct sched_param { #include <linux/errno.h> #include <linux/nodemask.h> #include <linux/mm_types.h> -#include <linux/vmacache.h> #include <linux/preempt_mask.h> #include <asm/page.h> @@ -131,6 +130,10 @@ struct perf_event_context; struct blk_plug; struct filename; +#define VMACACHE_BITS 2 +#define VMACACHE_SIZE (1U << VMACACHE_BITS) +#define VMACACHE_MASK (VMACACHE_SIZE - 1) + /* * List of flags we want to share for kernel threads, * if only because they are not used by them anyway. diff -puN include/linux/vmacache.h~mm-per-thread-vma-caching-fix-3 include/linux/vmacache.h --- a/include/linux/vmacache.h~mm-per-thread-vma-caching-fix-3 +++ a/include/linux/vmacache.h @@ -1,21 +1,19 @@ #ifndef __LINUX_VMACACHE_H #define __LINUX_VMACACHE_H +#include <linux/sched.h> #include <linux/mm.h> -#define VMACACHE_BITS 2 -#define VMACACHE_SIZE (1U << VMACACHE_BITS) -#define VMACACHE_MASK (VMACACHE_SIZE - 1) /* * Hash based on the page number. Provides a good hit rate for * workloads with good locality and those with random accesses as well. */ #define VMACACHE_HASH(addr) ((addr >> PAGE_SHIFT) & VMACACHE_MASK) -#define vmacache_flush(tsk) \ - do { \ - memset(tsk->vmacache, 0, sizeof(tsk->vmacache)); \ - } while (0) +static inline void vmacache_flush(struct task_struct *tsk) +{ + memset(tsk->vmacache, 0, sizeof(tsk->vmacache)); +} extern void vmacache_flush_all(struct mm_struct *mm); extern void vmacache_update(unsigned long addr, struct vm_area_struct *newvma); diff -puN kernel/debug/debug_core.c~mm-per-thread-vma-caching-fix-3 kernel/debug/debug_core.c --- a/kernel/debug/debug_core.c~mm-per-thread-vma-caching-fix-3 +++ a/kernel/debug/debug_core.c @@ -49,6 +49,7 @@ #include <linux/pid.h> #include <linux/smp.h> #include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/rcupdate.h> #include <asm/cacheflush.h> diff -puN kernel/fork.c~mm-per-thread-vma-caching-fix-3 kernel/fork.c --- a/kernel/fork.c~mm-per-thread-vma-caching-fix-3 +++ a/kernel/fork.c @@ -28,6 +28,8 @@ #include <linux/mman.h> #include <linux/mmu_notifier.h> #include <linux/fs.h> +#include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/nsproxy.h> #include <linux/capability.h> #include <linux/cpu.h> diff -puN mm/Makefile~mm-per-thread-vma-caching-fix-3 mm/Makefile diff -puN mm/mmap.c~mm-per-thread-vma-caching-fix-3 mm/mmap.c --- a/mm/mmap.c~mm-per-thread-vma-caching-fix-3 +++ a/mm/mmap.c @@ -10,6 +10,7 @@ #include <linux/slab.h> #include <linux/backing-dev.h> #include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/shm.h> #include <linux/mman.h> #include <linux/pagemap.h> diff -puN mm/nommu.c~mm-per-thread-vma-caching-fix-3 mm/nommu.c --- a/mm/nommu.c~mm-per-thread-vma-caching-fix-3 +++ a/mm/nommu.c @@ -15,6 +15,7 @@ #include <linux/export.h> #include <linux/mm.h> +#include <linux/vmacache.h> #include <linux/mman.h> #include <linux/swap.h> #include <linux/file.h> diff -puN mm/vmacache.c~mm-per-thread-vma-caching-fix-3 mm/vmacache.c --- a/mm/vmacache.c~mm-per-thread-vma-caching-fix-3 +++ a/mm/vmacache.c @@ -2,6 +2,7 @@ * Copyright (C) 2014 Davidlohr Bueso. */ #include <linux/sched.h> +#include <linux/mm.h> #include <linux/vmacache.h> /* _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are origin.patch arch-alpha-kernel-systblss-remove-debug-check.patch i-need-old-gcc.patch maintainers-akpm-maintenance.patch revert-kallsyms-fix-absolute-addresses-for-kaslr.patch input-route-kbd-leds-through-the-generic-leds-layer.patch ocfs2-add-dlm_recover_callback_support-in-sysfs-fix.patch ocfs2-flock-drop-cross-node-lock-when-failed-locally-checkpatch-fixes.patch ocfs2-do-not-return-dlm_migrate_response_mastery_ref-to-avoid-endlessloop-during-umount-checkpatch-fixes.patch mm.patch mm-hugetlb-improve-page-fault-scalability-fix.patch mm-vmstat-fix-up-zone-state-accounting-fix.patch mm-keep-page-cache-radix-tree-nodes-in-check-fix-fix.patch mm-process_vm_accessc-mark-function-as-static-fix.patch mm-hugetlbfs-fix-rmapping-for-anonymous-hugepages-with-page_pgoff-v3-fix.patch pagewalk-update-page-table-walker-core-fix-end-address-calculation-in-walk_page_range-fix.patch pagewalk-remove-argument-hmask-from-hugetlb_entry-fix-fix.patch mm-introduce-do_shared_fault-and-drop-do_fault-fix-fix.patch drop_caches-add-some-documentation-and-info-message.patch mmnuma-reorganize-change_pmd_range-fix.patch drivers-lguest-page_tablesc-rename-do_set_pte.patch mm-add-debugfs-tunable-for-fault_around_order-checkpatch-fixes.patch mm-per-thread-vma-caching.patch mm-per-thread-vma-caching-fix-3.patch mm-use-macros-from-compilerh-instead-of-__attribute__-fix.patch zram-use-zcomp-compressing-backends-fix.patch zram-return-error-valued-pointer-from-zcomp_create-fix.patch do_shared_fault-check-that-mmap_sem-is-held.patch include-linux-syscallsh-add-sys32_quotactl-prototype-fix.patch sys_sysfs-add-config_sysfs_syscall-fix.patch kernel-groupsc-remove-return-value-of-set_groups-fix.patch ncpfs-convert-dprintk-ddprintk-to-ncp_dbg-fix.patch ncpfs-convert-dprintk-ddprintk-to-ncp_dbg-fix-fix.patch hfsplus-fix-concurrent-acess-of-alloc_blocks-fix.patch hfsplus-fix-concurrent-acess-of-alloc_blocks-fix-fix.patch kmod-run-usermodehelpers-only-on-cpus-allowed-for-kthreadd-v2-fix.patch kmod-run-usermodehelpers-only-on-cpus-allowed-for-kthreadd-v2-checkpatch-fixes.patch include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix.patch kernel-panicc-display-reason-at-end-pr_emerg-fix.patch fault-injection-set-bounds-on-what-proc-self-make-it-fail-accepts-fix.patch initramfs-debug-detected-compression-method-fix.patch linux-next.patch drivers-gpio-gpio-zevioc-fix-build.patch debugging-keep-track-of-page-owners.patch journal_add_journal_head-debug.patch journal_add_journal_head-debug-fix.patch kernel-forkc-export-kernel_thread-to-modules.patch mutex-subsystem-synchro-test-module.patch slab-leaks3-default-y.patch put_bh-debug.patch a.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html