[nacked] kernel-sysc-reduce-required-permission-for-prctl_set_mm.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Subject: [nacked] kernel-sysc-reduce-required-permission-for-prctl_set_mm.patch removed from -mm tree
To: avagin@xxxxxxxxxx,adityakali@xxxxxxxxxx,ebiederm@xxxxxxxxxxxx,gang.chen@xxxxxxxxxxx,holt@xxxxxxx,keescook@xxxxxxxxxxxx,mtk.manpages@xxxxxxxxx,oleg@xxxxxxxxxx,sfr@xxxxxxxxxxxxxxxx,viro@xxxxxxxxxxxxxxxxxx,xemul@xxxxxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 12 Feb 2014 15:24:35 -0800


The patch titled
     Subject: kernel/sys.c: reduce required permission for prctl_set_mm
has been removed from the -mm tree.  Its filename was
     kernel-sysc-reduce-required-permission-for-prctl_set_mm.patch

This patch was dropped because it was nacked

------------------------------------------------------
From: Andrey Vagin <avagin@xxxxxxxxxx>
Subject: kernel/sys.c: reduce required permission for prctl_set_mm

Currently prctl_set_mm requires the global CAP_SYS_RESOURCE, this patch
reduce requiremence to CAP_SYS_RESOURCE in the current namespace.

When we restore a task we need to set up text, data and data heap sizes
from userspace to the values a task had at checkpoint time.

Currently we can not restore these parameters, if a task lives in a
non-root user name space, because it has no capabilities in the parent
namespace.

prctl_set_mm() changes parameters of the current task and doesn't affect
other tasks.

This patch affects the RLIMIT_DATA limit, because a consumtiuon is
calculated relatively to mm->end_data, mm->start_data, mm->start_brk.

rlim = rlimit(RLIMIT_DATA);
if (rlim < RLIM_INFINITY && (brk - mm->start_brk) +
		(mm->end_data - mm->start_data) > rlim)
	goto out;

This limit affects calls to brk() and sbrk(), but it doesn't affect
mmap. So I think requirement of CAP_SYS_RESOURCE in the current
namespace is enough for this limit.

Signed-off-by: Andrey Vagin <avagin@xxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: Robin Holt <holt@xxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Cc: Chen Gang <gang.chen@xxxxxxxxxxx>
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Cc: Pavel Emelyanov <xemul@xxxxxxxxxxxxx>
Cc: Aditya Kali <adityakali@xxxxxxxxxx>
Cc: Michael Kerrisk <mtk.manpages@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 kernel/sys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/sys.c~kernel-sysc-reduce-required-permission-for-prctl_set_mm kernel/sys.c
--- a/kernel/sys.c~kernel-sysc-reduce-required-permission-for-prctl_set_mm
+++ a/kernel/sys.c
@@ -1701,7 +1701,7 @@ static int prctl_set_mm(int opt, unsigne
 	if (arg5 || (arg4 && opt != PR_SET_MM_AUXV))
 		return -EINVAL;
 
-	if (!capable(CAP_SYS_RESOURCE))
+	if (!ns_capable(current_user_ns(), CAP_SYS_RESOURCE))
 		return -EPERM;
 
 	if (opt == PR_SET_MM_EXE_FILE)
_

Patches currently in -mm which might be from avagin@xxxxxxxxxx are

origin.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux