Subject: + kthread-ensure-locality-of-task_struct-allocations.patch added to -mm tree To: nacc@xxxxxxxxxxxxxxxxxx,anton@xxxxxxxxx,benh@xxxxxxxxxxxxxxxxxxx,cl@xxxxxxxxx,iamjoonsoo.kim@xxxxxxx,jack@xxxxxxx,liwanp@xxxxxxxxxxxxxxxxxx,oleg@xxxxxxxxxx,penguin-kernel@xxxxxxxxxxxxxxxxxxx,rientjes@xxxxxxxxxx,tglx@xxxxxxxxxxxxx,tj@xxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Fri, 31 Jan 2014 14:26:20 -0800 The patch titled Subject: kthread: ensure locality of task_struct allocations has been added to the -mm tree. Its filename is kthread-ensure-locality-of-task_struct-allocations.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/kthread-ensure-locality-of-task_struct-allocations.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/kthread-ensure-locality-of-task_struct-allocations.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Nishanth Aravamudan <nacc@xxxxxxxxxxxxxxxxxx> Subject: kthread: ensure locality of task_struct allocations In the presence of memoryless nodes, numa_node_id() will return the current CPU's NUMA node, but that may not be where we expect to allocate from memory from. Instead, we should rely on the fallback code in the memory allocator itself, by using NUMA_NO_NODE. Also, when calling kthread_create_on_node(), use the nearest node with memory to the cpu in question, rather than the node it is running on. Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxxxxxxxxxx> Reviewed-by: Christoph Lameter <cl@xxxxxxxxx> Acked-by: David Rientjes <rientjes@xxxxxxxxxx> Cc: Anton Blanchard <anton@xxxxxxxxx> Cc: Tejun Heo <tj@xxxxxxxxxx> Cc: Oleg Nesterov <oleg@xxxxxxxxxx> Cc: Jan Kara <jack@xxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> Cc: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> Cc: Ben Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/kthread.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN kernel/kthread.c~kthread-ensure-locality-of-task_struct-allocations kernel/kthread.c --- a/kernel/kthread.c~kthread-ensure-locality-of-task_struct-allocations +++ a/kernel/kthread.c @@ -217,7 +217,7 @@ int tsk_fork_get_node(struct task_struct if (tsk == kthreadd_task) return tsk->pref_node_fork; #endif - return numa_node_id(); + return NUMA_NO_NODE; } static void create_kthread(struct kthread_create_info *create) @@ -369,7 +369,7 @@ struct task_struct *kthread_create_on_cp { struct task_struct *p; - p = kthread_create_on_node(threadfn, data, cpu_to_node(cpu), namefmt, + p = kthread_create_on_node(threadfn, data, cpu_to_mem(cpu), namefmt, cpu); if (IS_ERR(p)) return p; _ Patches currently in -mm which might be from nacc@xxxxxxxxxxxxxxxxxx are origin.patch kthread-ensure-locality-of-task_struct-allocations.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html