Subject: [merged] fs-ramfs-dont-use-module_init-for-non-modular-core-code.patch removed from -mm tree To: paul.gortmaker@xxxxxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Wed, 22 Jan 2014 12:12:13 -0800 The patch titled Subject: fs/ramfs: don't use module_init for non-modular core code has been removed from the -mm tree. Its filename was fs-ramfs-dont-use-module_init-for-non-modular-core-code.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Subject: fs/ramfs: don't use module_init for non-modular core code The ramfs is always built in. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of fs_initcall (which makes sense for fs code) will thus change this registration from level 6-device to level 5-fs (i.e. slightly earlier). However no observable impact of that small difference has been observed during testing, or is expected. Also note that this change uncovers a missing semicolon bug in the registration of the initcall. Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ramfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/ramfs/inode.c~fs-ramfs-dont-use-module_init-for-non-modular-core-code fs/ramfs/inode.c --- a/fs/ramfs/inode.c~fs-ramfs-dont-use-module_init-for-non-modular-core-code +++ a/fs/ramfs/inode.c @@ -275,4 +275,4 @@ int __init init_ramfs_fs(void) return err; } -module_init(init_ramfs_fs) +fs_initcall(init_ramfs_fs); _ Patches currently in -mm which might be from paul.gortmaker@xxxxxxxxxxxxx are origin.patch mm-make-creation-of-the-mm_kobj-happen-earlier-than-device_initcall.patch mm-audit-fix-non-modular-users-of-module_init-in-core-code.patch kernel-audit-fix-non-modular-users-of-module_init-in-core-code.patch printk-flush-conflicting-continuation-line.patch printk-flush-conflicting-continuation-line-fix.patch fs-proc-dont-use-module_init-for-non-modular-core-code.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html