Subject: [merged] fs-read_writec-compat_readv-remove-bogus-area-verify.patch removed from -mm tree To: minyard@xxxxxxx,cminyard@xxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Wed, 22 Jan 2014 12:12:09 -0800 The patch titled Subject: fs/read_write.c:compat_readv(): remove bogus area verify has been removed from the -mm tree. Its filename was fs-read_writec-compat_readv-remove-bogus-area-verify.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Corey Minyard <minyard@xxxxxxx> Subject: fs/read_write.c:compat_readv(): remove bogus area verify The compat_do_readv_writev() function was doing a verify_area on the incoming iov, but the nr_segs value is not checked. If someone passes in a -1 for nr_segs, for instance, the function should return an EINVAL. However, it returns a EFAULT because the verify_area fails because it is checking an array of size MAX_UINT. The check is bogus, anyway, because the next check, compat_rw_copy_check_uvector(), will do all the necessary checking, anyway. The non-compat do_readv_writev() function doesn't do this check, so I think it's safe to just remove the code. Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/read_write.c | 4 ---- 1 file changed, 4 deletions(-) diff -puN fs/read_write.c~fs-read_writec-compat_readv-remove-bogus-area-verify fs/read_write.c --- a/fs/read_write.c~fs-read_writec-compat_readv-remove-bogus-area-verify +++ a/fs/read_write.c @@ -901,10 +901,6 @@ static ssize_t compat_do_readv_writev(in io_fn_t fn; iov_fn_t fnv; - ret = -EFAULT; - if (!access_ok(VERIFY_READ, uvector, nr_segs*sizeof(*uvector))) - goto out; - ret = compat_rw_copy_check_uvector(type, uvector, nr_segs, UIO_FASTIOV, iovstack, &iov); if (ret <= 0) _ Patches currently in -mm which might be from minyard@xxxxxxx are origin.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html