Subject: + headers_check-special-case-seqbuf_dump.patch added to -mm tree
To: pebolle@xxxxxxxxxx,arnd@xxxxxxxx,mmarek@xxxxxxx,tiwai@xxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 15 Jan 2014 15:10:51 -0800
The patch titled
From: Paul Bolle <pebolle@xxxxxxxxxx>
has been added to the -mm tree. Its filename is
headers_check-special-case-seqbuf_dump.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/headers_check-special-case-seqbuf_dump.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/headers_check-special-case-seqbuf_dump.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Paul Bolle <pebolle@xxxxxxxxxx>
Subject: headers_check: special case seqbuf_dump()
"make headers_check" warns about soundcard.h for (at least) five years
now:
[...]/usr/include/linux/soundcard.h:1054: userspace cannot reference function or variable defined in the kernel
We're apparently stuck with providing OSSlib-3.8 compatibility, so let's
special case this declaration just to silence it.
Notes:
0) Support for OSSlib post 3.8 was already removed in commit 43a990765a
("sound: Remove OSSlib stuff from linux/soundcard.h"). Five years have
passed since that commit: do people still care about OSSlib-3.8? If
not, quite a bit of code could be remove from soundcard.h (and probably
ultrasound.h).
2) By the way, what is actually meant by:
It is no longer possible to actually link against OSSlib with this
header, but we still provide these macros for programs using them.
Doesn't that mean compatibility to OSSlib isn't even useful?
3) Anyhow, a previous discussion soundcard.h, which led to that commit,
starts at https://lkml.org/lkml/2009/1/20/349 .
4) And, yes, I sneaked in a whitespace fix.
Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
Cc: Takashi Iwai <tiwai@xxxxxxx>
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Michal Marek <mmarek@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/headers_check.pl | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff -puN scripts/headers_check.pl~headers_check-special-case-seqbuf_dump scripts/headers_check.pl
--- a/scripts/headers_check.pl~headers_check-special-case-seqbuf_dump
+++ a/scripts/headers_check.pl
@@ -65,7 +65,11 @@ sub check_include
sub check_declarations
{
- if ($line =~m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
+ # soundcard.h is what it is
+ if ($line =~ m/^void seqbuf_dump\(void\);/) {
+ return;
+ }
+ if ($line =~ m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
printf STDERR "$filename:$lineno: " .
"userspace cannot reference function or " .
"variable defined in the kernel\n";
_
Patches currently in -mm which might be from pebolle@xxxxxxxxxx are
headers_check-special-case-seqbuf_dump.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
