Subject: [merged] audit-correct-a-type-mismatch-in-audit_syscall_exit.patch removed from -mm tree To: takahiro.akashi@xxxxxxxxxx,eparis@xxxxxxxxxx,stable@xxxxxxxxxxxxxxx,viro@xxxxxxxxxxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Wed, 15 Jan 2014 12:24:59 -0800 The patch titled Subject: audit: correct a type mismatch in audit_syscall_exit() has been removed from the -mm tree. Its filename was audit-correct-a-type-mismatch-in-audit_syscall_exit.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> Subject: audit: correct a type mismatch in audit_syscall_exit() audit_syscall_exit() saves a result of regs_return_value() in intermediate "int" variable and passes it to __audit_syscall_exit(), which expects its second argument as a "long" value. This will result in truncating the value returned by a system call and making a wrong audit record. I don't know why gcc compiler doesn't complain about this, but anyway it causes a problem at runtime on arm64 (and probably most 64-bit archs). Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Eric Paris <eparis@xxxxxxxxxx> Cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/audit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN include/linux/audit.h~audit-correct-a-type-mismatch-in-audit_syscall_exit include/linux/audit.h --- a/include/linux/audit.h~audit-correct-a-type-mismatch-in-audit_syscall_exit +++ a/include/linux/audit.h @@ -137,7 +137,7 @@ static inline void audit_syscall_exit(vo { if (unlikely(current->audit_context)) { int success = is_syscall_success(pt_regs); - int return_code = regs_return_value(pt_regs); + long return_code = regs_return_value(pt_regs); __audit_syscall_exit(success, return_code); } _ Patches currently in -mm which might be from takahiro.akashi@xxxxxxxxxx are linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html