Subject: + kdump-fix-exported-size-of-vmcoreinfo-note.patch added to -mm tree
To: vgoyal@xxxxxxxxxx,da-x@xxxxxxxxxxxxx,greg@xxxxxxxxx,oomichi@xxxxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Tue, 14 Jan 2014 15:37:19 -0800
The patch titled
Subject: kdump: fix exported size of vmcoreinfo note
has been added to the -mm tree. Its filename is
kdump-fix-exported-size-of-vmcoreinfo-note.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/kdump-fix-exported-size-of-vmcoreinfo-note.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/kdump-fix-exported-size-of-vmcoreinfo-note.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Vivek Goyal <vgoyal@xxxxxxxxxx>
Subject: kdump: fix exported size of vmcoreinfo note
Right now we seem to be exporting the max data size contained inside
vmcoreinfo note. But this does not include the size of meta data around
vmcore info data. Like name of the note and starting and ending elf_note.
I think user space expects total size and that size is put in PT_NOTE elf
header. Things seem to be fine so far because we are not using vmcoreinfo
note to the maximum capacity. But as it starts filling up, to capacity,
at some point of time, problem will be visible.
Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Cc: Ken'ichi Ohmichi <oomichi@xxxxxxxxxxxxxxxxx>
Cc: Dan Aloni <da-x@xxxxxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/ksysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/ksysfs.c~kdump-fix-exported-size-of-vmcoreinfo-note kernel/ksysfs.c
--- a/kernel/ksysfs.c~kdump-fix-exported-size-of-vmcoreinfo-note
+++ a/kernel/ksysfs.c
@@ -126,7 +126,7 @@ static ssize_t vmcoreinfo_show(struct ko
{
return sprintf(buf, "%lx %x\n",
paddr_vmcoreinfo_note(),
- (unsigned int)vmcoreinfo_max_size);
+ (unsigned int)sizeof(vmcoreinfo_note));
}
KERNEL_ATTR_RO(vmcoreinfo);
_
Patches currently in -mm which might be from vgoyal@xxxxxxxxxx are
crash_dump-fix-compilation-error-on-mips-at-least.patch
kexec-add-sysctl-to-disable-kexec_load.patch
kdump-fix-exported-size-of-vmcoreinfo-note.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
