Subject: + init-fix-possible-format-string-bug.patch added to -mm tree To: penguin-kernel@xxxxxxxxxxxxxxxxxxx,penguin-kernel@xxxxxxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Fri, 10 Jan 2014 15:49:28 -0800 The patch titled Subject: init: fix possible format string bug has been added to the -mm tree. Its filename is init-fix-possible-format-string-bug.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/init-fix-possible-format-string-bug.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/init-fix-possible-format-string-bug.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> Subject: init: fix possible format string bug Use constant format string in case message changes. Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- init/initramfs.c | 2 +- init/main.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff -puN init/initramfs.c~init-fix-possible-format-string-bug init/initramfs.c --- a/init/initramfs.c~init-fix-possible-format-string-bug +++ a/init/initramfs.c @@ -583,7 +583,7 @@ static int __init populate_rootfs(void) { char *err = unpack_to_rootfs(__initramfs_start, __initramfs_size); if (err) - panic(err); /* Failed to decompress INTERNAL initramfs */ + panic("%s", err); /* Failed to decompress INTERNAL initramfs */ if (initrd_start) { #ifdef CONFIG_BLK_DEV_RAM int fd; diff -puN init/main.c~init-fix-possible-format-string-bug init/main.c --- a/init/main.c~init-fix-possible-format-string-bug +++ a/init/main.c @@ -278,7 +278,7 @@ static int __init unknown_bootoption(cha unsigned int i; for (i = 0; envp_init[i]; i++) { if (i == MAX_INIT_ENVS) { - panic_later = "Too many boot env vars at `%s'"; + panic_later = "env"; panic_param = param; } if (!strncmp(param, envp_init[i], val - param)) @@ -290,7 +290,7 @@ static int __init unknown_bootoption(cha unsigned int i; for (i = 0; argv_init[i]; i++) { if (i == MAX_INIT_ARGS) { - panic_later = "Too many boot init vars at `%s'"; + panic_later = "init"; panic_param = param; } } @@ -582,7 +582,8 @@ asmlinkage void __init start_kernel(void */ console_init(); if (panic_later) - panic(panic_later, panic_param); + panic("Too many boot %s vars at `%s'", panic_later, + panic_param); lockdep_info(); _ Patches currently in -mm which might be from penguin-kernel@xxxxxxxxxxxxxxxxxxx are init-fix-possible-format-string-bug.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html