Subject: + backlight-ot200_bl-use-devm_backlight_device_register.patch added to -mm tree To: jg1.han@xxxxxxxxxxx,tomi.valkeinen@xxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 02 Dec 2013 17:00:34 -0800 The patch titled Subject: backlight: ot200_bl: use devm_backlight_device_register() has been added to the -mm tree. Its filename is backlight-ot200_bl-use-devm_backlight_device_register.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/backlight-ot200_bl-use-devm_backlight_device_register.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/backlight-ot200_bl-use-devm_backlight_device_register.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jingoo Han <jg1.han@xxxxxxxxxxx> Subject: backlight: ot200_bl: use devm_backlight_device_register() Use devm_backlight_device_register() to make cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/backlight/ot200_bl.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff -puN drivers/video/backlight/ot200_bl.c~backlight-ot200_bl-use-devm_backlight_device_register drivers/video/backlight/ot200_bl.c --- a/drivers/video/backlight/ot200_bl.c~backlight-ot200_bl-use-devm_backlight_device_register +++ a/drivers/video/backlight/ot200_bl.c @@ -118,8 +118,9 @@ static int ot200_backlight_probe(struct props.brightness = 100; props.type = BACKLIGHT_RAW; - bl = backlight_device_register(dev_name(&pdev->dev), &pdev->dev, data, - &ot200_backlight_ops, &props); + bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev), + &pdev->dev, data, &ot200_backlight_ops, + &props); if (IS_ERR(bl)) { dev_err(&pdev->dev, "failed to register backlight\n"); retval = PTR_ERR(bl); @@ -137,10 +138,6 @@ error_devm_kzalloc: static int ot200_backlight_remove(struct platform_device *pdev) { - struct backlight_device *bl = platform_get_drvdata(pdev); - - backlight_device_unregister(bl); - /* on module unload set brightness to 100% */ cs5535_mfgpt_write(pwm_timer, MFGPT_REG_COUNTER, 0); cs5535_mfgpt_write(pwm_timer, MFGPT_REG_SETUP, MFGPT_SETUP_CNTEN); _ Patches currently in -mm which might be from jg1.han@xxxxxxxxxxx are drivers-block-sx8c-use-module_pci_driver.patch drivers-block-sx8c-remove-unnecessary-pci_set_drvdata.patch backlight-jornada720-use-devm_backlight_device_register.patch backlight-hp680_bl-use-devm_backlight_device_register.patch backlight-omap1-use-devm_backlight_device_register.patch backlight-ot200_bl-use-devm_backlight_device_register.patch backlight-tosa-use-devm_backlight_device_register.patch backlight-jornada720-use-devm_lcd_device_register.patch backlight-l4f00242t03-use-devm_lcd_device_register.patch backlight-tosa-use-devm_lcd_device_register.patch drivers-rtc-rtc-as3722-use-devm-for-rtc-and-irq-registration.patch rtc-ds1305-remove-unnecessary-spi_set_drvdata.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html