Subject: + rtc-ds1305-remove-unnecessary-spi_set_drvdata.patch added to -mm tree To: jg1.han@xxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 25 Nov 2013 14:30:53 -0800 The patch titled Subject: drivers/rtc/rtc-ds1305.c: remove unnecessary spi_set_drvdata() has been added to the -mm tree. Its filename is rtc-ds1305-remove-unnecessary-spi_set_drvdata.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/rtc-ds1305-remove-unnecessary-spi_set_drvdata.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/rtc-ds1305-remove-unnecessary-spi_set_drvdata.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Jingoo Han <jg1.han@xxxxxxxxxxx> Subject: drivers/rtc/rtc-ds1305.c: remove unnecessary spi_set_drvdata() The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-ds1305.c | 1 - 1 file changed, 1 deletion(-) diff -puN drivers/rtc/rtc-ds1305.c~rtc-ds1305-remove-unnecessary-spi_set_drvdata drivers/rtc/rtc-ds1305.c --- a/drivers/rtc/rtc-ds1305.c~rtc-ds1305-remove-unnecessary-spi_set_drvdata +++ a/drivers/rtc/rtc-ds1305.c @@ -787,7 +787,6 @@ static int ds1305_remove(struct spi_devi cancel_work_sync(&ds1305->work); } - spi_set_drvdata(spi, NULL); return 0; } _ Patches currently in -mm which might be from jg1.han@xxxxxxxxxxx are drivers-block-sx8c-use-module_pci_driver.patch drivers-block-sx8c-remove-unnecessary-pci_set_drvdata.patch drivers-rtc-rtc-as3722-use-devm-for-rtc-and-irq-registration.patch rtc-ds1305-remove-unnecessary-spi_set_drvdata.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html