Subject: + drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling.patch added to -mm tree To: dan.carpenter@xxxxxxxxxx,gregkh@xxxxxxxxxxxxxxxxxxx,omar.ramirez@xxxxxxxxxx,s-anna@xxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Fri, 22 Nov 2013 15:29:33 -0800 The patch titled Subject: drivers/mailbox/omap: make mbox->irq signed for error handling has been added to the -mm tree. Its filename is drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Subject: drivers/mailbox/omap: make mbox->irq signed for error handling There is a bug in omap2_mbox_probe() where we try do: mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) { The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed it to a signed integer. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Cc: Suman Anna <s-anna@xxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Omar Ramirez Luna <omar.ramirez@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/mailbox/omap-mbox.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/mailbox/omap-mbox.h~drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling drivers/mailbox/omap-mbox.h --- a/drivers/mailbox/omap-mbox.h~drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling +++ a/drivers/mailbox/omap-mbox.h @@ -52,7 +52,7 @@ struct omap_mbox_queue { struct omap_mbox { const char *name; - unsigned int irq; + int irq; struct omap_mbox_queue *txq, *rxq; struct omap_mbox_ops *ops; struct device *dev; _ Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are origin.patch drivers-scsi-megaraid-megaraid_mmc-missing-bounds-check-in-mimd_to_kioc.patch drivers-block-paride-pgc-underflow-bug-in-pg_write.patch xfs-underflow-bug-in-xfs_attrlist_by_handle.patch drivers-mailbox-omap-make-mbox-irq-signed-for-error-handling.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html