Subject: [folded-merged] debugging-keep-track-of-page-owners-fix-2.patch removed from -mm tree
To: minchan@xxxxxxxxxx,dave@xxxxxxxxxxxxxxxxxx,mina86@xxxxxxxxxx,rdunlap@xxxxxxxxxxxxx,mm-commits@xxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Fri, 15 Nov 2013 14:24:02 -0800
The patch titled
Subject: Fix wrong EOF compare
has been removed from the -mm tree. Its filename was
debugging-keep-track-of-page-owners-fix-2.patch
This patch was dropped because it was folded into debugging-keep-track-of-page-owners.patch
------------------------------------------------------
From: Minchan Kim <minchan@xxxxxxxxxx>
Subject: Fix wrong EOF compare
The C standards allows the character type char to be singed or unsinged,
depending on the platform and compiler. Most of systems uses signed char,
but those based on PowerPC and ARM processors typically use unsigned char.
This can lead to unexpected results when the variable is used to compare
with EOF(-1). It happens my ARM system and this patch fixes it.
Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>
Cc: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>
Cc: Michal Nazarewicz <mina86@xxxxxxxxxx>
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
Documentation/page_owner.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff -puN Documentation/page_owner.c~debugging-keep-track-of-page-owners-fix-2 Documentation/page_owner.c
--- a/Documentation/page_owner.c~debugging-keep-track-of-page-owners-fix-2
+++ a/Documentation/page_owner.c
@@ -32,12 +32,13 @@ int read_block(char *buf, FILE *fin)
{
int ret = 0;
int hit = 0;
+ int val;
char *curr = buf;
for (;;) {
- *curr = getc(fin);
- if (*curr == EOF) return -1;
-
+ val = getc(fin);
+ if (val == EOF) return -1;
+ *curr = val;
ret++;
if (*curr == '\n' && hit == 1)
return ret - 1;
_
Patches currently in -mm which might be from minchan@xxxxxxxxxx are
origin.patch
swap-fix-setting-page_size-blocksize-during-swapoff-swapon-race.patch
swap-add-a-simple-detector-for-inappropriate-swapin-readahead.patch
linux-next.patch
debugging-keep-track-of-page-owners.patch
debugging-keep-track-of-page-owners-fix-2-fix.patch
debugging-keep-track-of-page-owners-fix-2-fix-fix.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
