Subject: + lib-decompress_unlz4c-always-set-an-error-return-code-on-failures.patch added to -mm tree
To: JBeulich@xxxxxxxx,jbeulich@xxxxxxxx,kyungsik.lee@xxxxxxx,mattjd@xxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Mon, 11 Nov 2013 13:50:50 -0800
The patch titled
Subject: lib/decompress_unlz4.c: always set an error return code on failures
has been added to the -mm tree. Its filename is
lib-decompress_unlz4c-always-set-an-error-return-code-on-failures.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-decompress_unlz4c-always-set-an-error-return-code-on-failures.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-decompress_unlz4c-always-set-an-error-return-code-on-failures.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Subject: lib/decompress_unlz4.c: always set an error return code on failures
"ret", being set to -1 early on, gets cleared by the first invocation of
lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence subsequent
failures wouldn't be noticed by the caller without setting it back to -1
right after those calls.
Reported-by: Matthew Daley <mattjd@xxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Kyungsik Lee <kyungsik.lee@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/decompress_unlz4.c | 1 +
1 file changed, 1 insertion(+)
diff -puN lib/decompress_unlz4.c~lib-decompress_unlz4c-always-set-an-error-return-code-on-failures lib/decompress_unlz4.c
--- a/lib/decompress_unlz4.c~lib-decompress_unlz4c-always-set-an-error-return-code-on-failures
+++ a/lib/decompress_unlz4.c
@@ -141,6 +141,7 @@ STATIC inline int INIT unlz4(u8 *input,
goto exit_2;
}
+ ret = -1;
if (flush && flush(outp, dest_len) != dest_len)
goto exit_2;
if (output)
_
Patches currently in -mm which might be from JBeulich@xxxxxxxx are
lib-decompress_unlz4c-always-set-an-error-return-code-on-failures.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
