Subject: + framework-for-version-lvb-remove-some-impossible-checks.patch added to -mm tree
To: dan.carpenter@xxxxxxxxxx,jlbec@xxxxxxxxxxxx,mfasheh@xxxxxxxx,rgoldwyn@xxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Thu, 07 Nov 2013 13:43:31 -0800
The patch titled
Subject: ocfs2: remove some impossible checks
has been added to the -mm tree. Its filename is
framework-for-version-lvb-remove-some-impossible-checks.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/framework-for-version-lvb-remove-some-impossible-checks.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/framework-for-version-lvb-remove-some-impossible-checks.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: ocfs2: remove some impossible checks
pv_major and pv_minor are unsigned char type so these checks are just
noise.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Cc: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
Cc: Joel Becker <jlbec@xxxxxxxxxxxx>
Cc: Mark Fasheh <mfasheh@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/ocfs2/stack_user.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff -puN fs/ocfs2/stack_user.c~framework-for-version-lvb-remove-some-impossible-checks fs/ocfs2/stack_user.c
--- a/fs/ocfs2/stack_user.c~framework-for-version-lvb-remove-some-impossible-checks
+++ a/fs/ocfs2/stack_user.c
@@ -806,11 +806,7 @@ static int lvb_to_version(char *lvb, str
&ocfs2_user_plugin.sp_max_proto;
memcpy(&pv, lvb, sizeof(struct ocfs2_protocol_version));
- if ((pv.pv_major == LONG_MIN) || (pv.pv_major == LONG_MAX) ||
- (pv.pv_major > (u8)-1) || (pv.pv_major < 1))
- return -ERANGE;
- if ((pv.pv_minor == LONG_MIN) || (pv.pv_minor == LONG_MAX) ||
- (pv.pv_minor > (u8)-1) || (pv.pv_minor < 0))
+ if (pv.pv_major < 1)
return -ERANGE;
if ((pv.pv_major != max->pv_major) ||
(pv.pv_minor > max->pv_minor))
_
Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are
origin.patch
ocfs2-add-missing-errno-in-ocfs2_ioctl_move_extents.patch
framework-for-version-lvb-remove-some-impossible-checks.patch
drivers-block-paride-pgc-underflow-bug-in-pg_write.patch
xfs-underflow-bug-in-xfs_attrlist_by_handle.patch
backlight-lm3630-signedness-bug-in-lm3630a_chip_init.patch
backlight-lm3630-potential-null-deref-in-probe.patch
pktcdvd-debugfs-functions-return-null-on-error.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
