The patch titled pr_debug: check pr_debug() arguments has been added to the -mm tree. Its filename is pr_debug-check-pr_debug-arguments.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: pr_debug: check pr_debug() arguments From: Zach Brown <zach.brown@xxxxxxxxxx> check pr_debug() arguments When DEBUG isn't defined pr_debug() is defined away as an empty macro. By throwing away the arguments we allow completely incorrect code to build. Instead let's make it an empty inline which checks arguments and mark it so gcc can check the format specification. This results in a seemingly insignificant code size increase. A x86-64 allyesconfig: text data bss dec hex filename 25354768 7191098 4854720 37400586 23ab00a vmlinux.before 25354945 7191138 4854720 37400803 23ab0e3 vmlinux Signed-off-by: Zach Brown <zach.brown@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- include/linux/kernel.h | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff -puN include/linux/kernel.h~pr_debug-check-pr_debug-arguments include/linux/kernel.h --- a/include/linux/kernel.h~pr_debug-check-pr_debug-arguments +++ a/include/linux/kernel.h @@ -216,8 +216,10 @@ extern void dump_stack(void); #define pr_debug(fmt,arg...) \ printk(KERN_DEBUG fmt,##arg) #else -#define pr_debug(fmt,arg...) \ - do { } while (0) +static inline int __attribute__ ((format (printf, 1, 2))) pr_debug(const char * fmt, ...) +{ + return 0; +} #endif #define pr_info(fmt,arg...) \ _ Patches currently in -mm which might be from zach.brown@xxxxxxxxxx are git-ocfs2.patch add-vector-aio-support.patch add-vector-aio-support-fix.patch pr_debug-aio-use-size_t-length-modifier-in-pr_debug-format-arguments.patch pr_debug-configfs-use-size_t-length-modifier-in-pr_debug-format-argument.patch pr_debug-sysfs-use-size_t-length-modifier-in-pr_debug-format-arguments.patch pr_debug-umem-repair-nonexistant-bh-pr_debug-reference.patch pr_debug-tipar-repair-nonexistant-pr_debug-argument-use.patch pr_debug-dell_rbu-fix-pr_debug-argument-warnings.patch pr_debug-ifb-replace-missing-comma-to-separate-pr_debug-arguments.patch pr_debug-trident-use-size_t-length-modifier-in-pr_debug-format-arguments.patch pr_debug-check-pr_debug-arguments.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html