The patch titled request_firmware examples has been removed from the -mm tree. Its filename is request_firmware-examples-and-module_firmware.patch This patch was dropped because it is obsolete ------------------------------------------------------ Subject: request_firmware examples From: Victor Hugo <victor@xxxxxxxxx> Return-Path: <victor@xxxxxxxxx> Received: from localhost (bix [127.0.0.1]) by localhost.localdomain (8.12.10/8.12.10) with ESMTP id k86Aimaj004744 for <akpm@localhost>; Wed, 6 Sep 2006 03:44:49 -0700 Received: from bix [127.0.0.1] by localhost with POP3 (fetchmail-6.2.0) for akpm@localhost (single-drop); Wed, 06 Sep 2006 03:44:49 -0700 (PDT) Received: from smtp.osdl.org (smtp.osdl.org [65.172.181.4]) by shell0.pdx.osdl.net (8.13.1/8.11.6) with ESMTP id k86AkXSu004711 for <akpm@xxxxxxxxxxxxxxxxxxxxx>; Wed, 6 Sep 2006 03:46:33 -0700 Received: from smtp103.biz.mail.re2.yahoo.com (smtp103.biz.mail.re2.yahoo.com [68.142.229.217]) by smtp.osdl.org (8.12.8/8.12.8) with SMTP id k86AkMnV021754 for <akpm@xxxxxxxx>; Wed, 6 Sep 2006 03:46:25 -0700 Received: (qmail 69061 invoked from network); 6 Sep 2006 09:41:01 -0000 Received: from unknown (HELO ?192.168.1.33?) (victor@xxxxxxxxx@64.121.37.19 with plain) by smtp103.biz.mail.re2.yahoo.com with SMTP; 6 Sep 2006 09:41:00 -0000 Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <BDE12841-B459-4D34-B15F-86C8A52A7D82@xxxxxxxxx> Cc: Jon Masters <jonathan@xxxxxxxxxxxxxx>, akpm@xxxxxxxx, mm-commits@xxxxxxxxxxxxxxx Content-Transfer-Encoding: 7bit Subject: [PATCH]request_firmware examples Date: Wed, 6 Sep 2006 02:40:57 -0700 To: linux-kernel@xxxxxxxxxxxxxxx X-Mailer: Apple Mail (2.752.2) Received-SPF: none (domain of victor@xxxxxxxxx does not designate permitted sender hosts) X-MIMEDefang-Filter: osdl$Revision: 1.146 $ X-Scanned-By: MIMEDefang 2.36 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on bix X-Spam-Level: X-Spam-Status: No, score=-1.5 required=2.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 Hey all, Here's the new patch for the firmware loader example drivers, fixed possible stack overflow in original example file. Signed-off-by: Victor Hugo <victor@xxxxxxxxx> --- diff -Nur linux-2.6.17.11/Documentation/firmware_class/ firmware_example.c linux/Documentation/firmware_class/firmware_example.c --- linux-2.6.17.11/Documentation/firmware_class/ firmware_example.c 1969-12-31 16:00:00.000000000 -0800 +++ linux/Documentation/firmware_class/firmware_example.c 2006-09-06 00:57:45.000000000 -0700 @@ -0,0 +1,68 @@ +/* + * firmware_example.c - + * + * Copyright (c) 2006 Victor Hugo <victor@xxxxxxxxx> + * Based on firmware_sample_driver.c by Manuel Estrada Sainz + * Sample code on how to use request_firmware() from drivers. + * + */ + +#include <linux/module.h> +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/device.h> +#include <linux/string.h> +#include <linux/firmware.h> + +static void sample_firmware_load(char *firmware, int size) +{ + u8 *buf = kmalloc(size + 1, GFP_KERNEL); + memcpy(buf, firmware, size); + buf[size] = '\0'; + printk(KERN_INFO "firmware_example: Firmware: %s\n", buf); + kfree(buf); +} + +static void sample_probe(struct device *dev) +{ + /* uses the default method to get the firmware */ + const struct firmware *fw_entry; + printk(KERN_INFO "firmware_example: ghost device inserted\n"); + + if (request_firmware(&fw_entry, "sample_firware.bin", dev) != 0) { + printk(KERN_ERR "firmware_example: Firmware not available\n"); + return; + } + + sample_firmware_load(fw_entry->data, fw_entry->size); + + release_firmware(fw_entry); + + /* finish setting up the device */ +} + +static void ghost_release(struct device *dev) +{ + printk(KERN_DEBUG "firmware_example : ghost device released\n"); +} + +static struct device ghost_device = { + .bus_id = "ghost0", + .release = ghost_release +}; + +static int __init sample_init(void) +{ + device_register(&ghost_device); + sample_probe(&ghost_device); + return 0; +} +static void __exit sample_exit(void) +{ + device_unregister(&ghost_device); +} + +module_init(sample_init); +module_exit(sample_exit); + +MODULE_LICENSE("GPL"); diff -Nur linux-2.6.17.11/Documentation/firmware_class/ firmware_nowait_example.c linux/Documentation/firmware_class/ firmware_nowait_example.c --- linux-2.6.17.11/Documentation/firmware_class/ firmware_nowait_example.c 1969-12-31 16:00:00.000000000 -0800 +++ linux/Documentation/firmware_class/ firmware_nowait_example.c 2006-09-06 00:58:06.000000000 -0700 @@ -0,0 +1,83 @@ +/* + * firmware_nowait_example.c - + * + * Copyright (c) 2006 Victor Hugo <victor@xxxxxxxxx> + * Based on firmware_sample_driver.c by Manuel Estrada Sainz + * Sample code on how to use request_firmware() from drivers. + * + */ + +#include <linux/module.h> +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/device.h> +#include <linux/string.h> +#include <linux/firmware.h> + +static void sample_firmware_load(char *firmware, int size) +{ + u8 *buf = kmalloc(size + 1, GFP_KERNEL); + memcpy(buf, firmware, size); + buf[size] = '\0'; + printk(KERN_INFO "firmware_example: Firmware: %s\n", buf); + kfree(buf); +} + +static void sample_probe_async_cont(const struct firmware *fw, void *context) +{ + if (!fw) { + printk(KERN_ERR + "firmware_nowait_example: Firmware not available\n"); + return; + } + + printk(KERN_INFO "firmware_nowait_example: Device Pointer \"%s \"\n", + (char *)context); + sample_firmware_load(fw->data, fw->size); + +} + +static void sample_probe_async(struct device *dev) +{ + /* Let's say I can't sleep */ + int error; + + printk(KERN_INFO "firmware_example: ghost device inserted\n"); + + error = request_firmware_nowait(THIS_MODULE, FW_ACTION_NOHOTPLUG, + "sample_firmware.bin", dev, + "my device pointer", + sample_probe_async_cont); + + if (error) { + printk(KERN_ERR + "firmware_nowait_example: request_firmware_nowait Failed\n"); + } + +} + +static void ghost_release(struct device *dev) +{ + printk(KERN_DEBUG "firmware_nowait_example: ghost device released\n"); +} + +static struct device ghost_device = { + .bus_id = "ghost0", + .release = ghost_release +}; + +static int __init sample_init(void) +{ + device_register(&ghost_device); + sample_probe_async(&ghost_device); + return 0; +} +static void __exit sample_exit(void) +{ + device_unregister(&ghost_device); +} + +module_init(sample_init); +module_exit(sample_exit); + +MODULE_LICENSE("GPL"); diff -Nur linux-2.6.17.11/Documentation/firmware_class/ firmware_sample_driver.c linux/Documentation/firmware_class/ firmware_sample_driver.c --- linux-2.6.17.11/Documentation/firmware_class/ firmware_sample_driver.c 2006-08-23 14:16:33.000000000 -0700 +++ linux/Documentation/firmware_class/firmware_sample_driver.c 1969-12-31 16:00:00.000000000 -0800 @@ -1,115 +0,0 @@ -/* - * firmware_sample_driver.c - - * - * Copyright (c) 2003 Manuel Estrada Sainz <ranty@xxxxxxxxxx> - * - * Sample code on how to use request_firmware() from drivers. - * - */ - -#include <linux/module.h> -#include <linux/kernel.h> -#include <linux/init.h> -#include <linux/device.h> -#include <linux/string.h> - -#include "linux/firmware.h" - -static struct device ghost_device = { - .bus_id = "ghost0", -}; - - -static void sample_firmware_load(char *firmware, int size) -{ - u8 buf[size+1]; - memcpy(buf, firmware, size); - buf[size] = '\0'; - printk(KERN_INFO "firmware_sample_driver: firmware: %s\n", buf); -} - -static void sample_probe_default(void) -{ - /* uses the default method to get the firmware */ - const struct firmware *fw_entry; - printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n"); - - if(request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0) - { - printk(KERN_ERR - "firmware_sample_driver: Firmware not available \n"); - return; - } - - sample_firmware_load(fw_entry->data, fw_entry->size); - - release_firmware(fw_entry); - - /* finish setting up the device */ -} -static void sample_probe_specific(void) -{ - /* Uses some specific hotplug support to get the firmware from - * userspace directly into the hardware, or via some sysfs file */ - - /* NOTE: This currently doesn't work */ - - printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n"); - - if(request_firmware(NULL, "sample_driver_fw", &ghost_device)! =0) - { - printk(KERN_ERR - "firmware_sample_driver: Firmware load failed \n"); - return; - } - - /* request_firmware blocks until userspace finished, so at - * this point the firmware should be already in the device */ - - /* finish setting up the device */ -} -static void sample_probe_async_cont(const struct firmware *fw, void *context) -{ - if(!fw){ - printk(KERN_ERR - "firmware_sample_driver: firmware load failed \n"); - return; - } - - printk(KERN_INFO "firmware_sample_driver: device pointer \"%s \"\n", - (char *)context); - sample_firmware_load(fw->data, fw->size); -} -static void sample_probe_async(void) -{ - /* Let's say that I can't sleep */ - int error; - error = request_firmware_nowait (THIS_MODULE, FW_ACTION_NOHOTPLUG, - "sample_driver_fw", &ghost_device, - "my device pointer", - sample_probe_async_cont); - if(error){ - printk(KERN_ERR - "firmware_sample_driver:" - " request_firmware_nowait failed\n"); - } -} - -static int sample_init(void) -{ - device_initialize(&ghost_device); - /* since there is no real hardware insertion I just call the - * sample probe functions here */ - sample_probe_specific(); - sample_probe_default(); - sample_probe_async(); - return 0; -} -static void __exit sample_exit(void) -{ -} - -module_init (sample_init); -module_exit (sample_exit); - -MODULE_LICENSE("GPL"); Patches currently in -mm which might be from victor@xxxxxxxxx are request_firmware-examples-and-module_firmware.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html