- signedness-issue-in-drivers-net-3c515c.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     Signedness issue in drivers/net/3c515.c

has been removed from the -mm tree.  Its filename is

     signedness-issue-in-drivers-net-3c515c.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
Subject: Signedness issue in drivers/net/3c515.c
From: Eric Sesterhenn <snakebyte@xxxxxx>

While playing with gcc 4.1 -Wextra warnings, I came across this one:

drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true

Since i is unsigned the >= 0 check in the for loop is always true, so we
might spin there forever unless the if condition triggers.  Since i is only
used in this loop, this patch changes it to an integer.

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>
Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/net/3c515.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/net/3c515.c~signedness-issue-in-drivers-net-3c515c drivers/net/3c515.c
--- a/drivers/net/3c515.c~signedness-issue-in-drivers-net-3c515c
+++ a/drivers/net/3c515.c
@@ -1003,7 +1003,8 @@ static int corkscrew_start_xmit(struct s
 		/* Calculate the next Tx descriptor entry. */
 		int entry = vp->cur_tx % TX_RING_SIZE;
 		struct boom_tx_desc *prev_entry;
-		unsigned long flags, i;
+		unsigned long flags;
+		int i;
 
 		if (vp->tx_full)	/* No room to transmit with */
 			return 1;
_

Patches currently in -mm which might be from snakebyte@xxxxxx are

git-gfs2.patch
git-intelfb.patch
git-netdev-all.patch
signedness-issue-in-drivers-net-phy-phy_devicec.patch
signedness-issue-in-drivers-scsi-iprc.patch
signedness-issue-in-drivers-scsi-osstc.patch
signedness-issue-in-drivers-usb-gadget-etherc.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux