The patch titled freevxfs: fix leak on error path has been added to the -mm tree. Its filename is freevxfs-fix-leak-on-error-path.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: freevxfs: fix leak on error path From: Alexey Dobriyan <adobriyan@xxxxxxxxx> If register_filesystem() fails, vxfs_inode cache must be destroyed. Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- fs/freevxfs/vxfs_super.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff -puN fs/freevxfs/vxfs_super.c~freevxfs-fix-leak-on-error-path fs/freevxfs/vxfs_super.c --- a/fs/freevxfs/vxfs_super.c~freevxfs-fix-leak-on-error-path +++ a/fs/freevxfs/vxfs_super.c @@ -260,12 +260,17 @@ static struct file_system_type vxfs_fs_t static int __init vxfs_init(void) { + int rv; + vxfs_inode_cachep = kmem_cache_create("vxfs_inode", sizeof(struct vxfs_inode_info), 0, SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD, NULL, NULL); - if (vxfs_inode_cachep) - return register_filesystem(&vxfs_fs_type); - return -ENOMEM; + if (!vxfs_inode_cachep) + return -ENOMEM; + rv = register_filesystem(&vxfs_fs_type); + if (rv < 0) + kmem_cache_destroy(vxfs_inode_cachep); + return rv; } static void __exit _ Patches currently in -mm which might be from adobriyan@xxxxxxxxx are fix-docs-for-fssuid_dumpable-6145.patch asus_acpi-fix-proc-files-parsing.patch asus_acpi-dont-printk-on-writing-garbage-to-proc-files.patch emu10k1x-simplify-around-pci_register_driver.patch git-agpgart.patch agph-constify-struct-agp_bridge_dataversion.patch ks0127-wire-up-i2c_add_driver-return-value.patch config_pm=n-slim-drivers-ieee1394-ohci1394c.patch config_pm=n-slim-drivers-scsi-sata_sil.patch git-netdev-all.patch config_pm=n-slim-drivers-pcmcia.patch i82092-wire-up-errors-from-pci_register_driver.patch config_pm=n-slim-drivers-serial-8250_pcic.patch megaraid-fix-warnings-when-config_proc_fs=n.patch turn-usb_resume_both-into-static-inline.patch git-xfs.patch sh-fix-fpn_start-typo.patch headers_check-improve-include-regexp.patch headers_check-clarify-error-message.patch task_struct-ifdef-missedem-v-ipc.patch ifdef-blktrace-debugging-fields.patch tty_ioc-keep-davej-sane.patch ifdef-quota_read-quota_write.patch reiserfs-ifdef-xattr_sem.patch reiserfs-ifdef-acl-stuff-from-inode.patch fsh-ifdef-security-fields.patch config_pm=n-slim-drivers-parport-parport_serialc.patch config_pm=n-slim-sound-oss-tridentc.patch config_pm=n-slim-sound-oss-cs46xxc.patch windfarm_smu_satc-simplify-around-i2c_add_driver.patch cramfs-rewrite-init_cramfs_fs.patch freevxfs-fix-leak-on-error-path.patch cramfs-make-cramfs_uncompress_exit-return-void.patch 9p-fix-leak-on-error-path.patch ban-register_filesystemnull.patch jbd-use-build_bug_on-in-journal-init.patch remove-null-check-in-register_nls.patch config_pm=n-slim-drivers-ide-pci-sc1200c.patch fs-kconfig-split-ext2.patch fs-kconfig-split-ext3.patch fs-kconfig-split-jbd.patch fs-kconfig-split-reiserfs.patch fs-kconfig-split-jfs.patch fs-kconfig-split-ocfs2.patch fs-kconfig-split-minix.patch fs-kconfig-split-romfs.patch fs-kconfig-split-autofs.patch fs-kconfig-split-autofs4.patch fs-kconfig-split-fuse.patch fs-kconfig-split-isofs.patch fs-kconfig-split-udf.patch fs-kconfig-split-fat.patch fs-kconfig-split-msdos.patch fs-kconfig-split-vfat.patch fs-kconfig-split-ntfs.patch fs-kconfig-split-proc.patch fs-kconfig-split-sysfs.patch fs-kconfig-split-hugetlbfs.patch fs-kconfig-split-ramfs.patch fs-kconfig-split-configfs.patch fs-kconfig-split-adfs.patch fs-kconfig-split-affs.patch fs-kconfig-split-ecryptfs.patch fs-kconfig-split-hfs.patch fs-kconfig-split-hfsplus.patch fs-kconfig-split-befs.patch fs-kconfig-split-bfs.patch fs-kconfig-split-efs.patch fs-kconfig-split-jffs.patch fs-kconfig-split-jffs2.patch fs-kconfig-split-cramfs.patch fs-kconfig-split-freevxfs.patch fs-kconfig-split-hpfs.patch fs-kconfig-split-qnx4.patch fs-kconfig-split-sysv.patch fs-kconfig-split-ufs.patch fs-kconfig-split-smbfs.patch fs-kconfig-split-cifs.patch fs-kconfig-split-ncpfs.patch fs-kconfig-split-coda.patch fs-kconfig-split-afs.patch fs-kconfig-split-9p.patch documentation-ioctl-messtxt-start-tree-wide-ioctl-registry.patch ioctl-messtxt-xfs-typos.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html