The patch titled
asus_acpi: don't printk on writing garbage to proc files
has been added to the -mm tree. Its filename is
asus_acpi-dont-printk-on-writing-garbage-to-proc-files.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: asus_acpi: don't printk on writing garbage to proc files
From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
* This reporting is useless (you get errno anyway).
* This reporting is already inconsistent in driver.
* Looks like created files in proc are rw-rw-rw- by default.
Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/acpi/asus_acpi.c | 10 +---------
1 files changed, 1 insertion(+), 9 deletions(-)
diff -puN drivers/acpi/asus_acpi.c~asus_acpi-dont-printk-on-writing-garbage-to-proc-files drivers/acpi/asus_acpi.c
--- a/drivers/acpi/asus_acpi.c~asus_acpi-dont-printk-on-writing-garbage-to-proc-files
+++ a/drivers/acpi/asus_acpi.c
@@ -629,9 +629,7 @@ proc_write_ledd(struct file *file, const
"Asus ACPI: LED display write failed\n");
else
hotk->ledd_status = (u32) value;
- } else if (rv < 0)
- printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
+ }
return rv;
}
@@ -849,10 +847,7 @@ proc_write_brn(struct file *file, const
value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
/* 0 <= value <= 15 */
set_brightness(value);
- } else if (rv < 0) {
- printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
}
-
return rv;
}
@@ -897,9 +892,6 @@ proc_write_disp(struct file *file, const
rv = parse_arg(buffer, count, &value);
if (rv > 0)
set_display(value);
- else if (rv < 0)
- printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
return rv;
}
_
Patches currently in -mm which might be from adobriyan@xxxxxxxxx are
fix-docs-for-fssuid_dumpable-6145.patch
asus_acpi-fix-proc-files-parsing.patch
asus_acpi-dont-printk-on-writing-garbage-to-proc-files.patch
emu10k1x-simplify-around-pci_register_driver.patch
git-agpgart.patch
agph-constify-struct-agp_bridge_dataversion.patch
ks0127-wire-up-i2c_add_driver-return-value.patch
config_pm=n-slim-drivers-ieee1394-ohci1394c.patch
config_pm=n-slim-drivers-scsi-sata_sil.patch
git-netdev-all.patch
config_pm=n-slim-drivers-pcmcia.patch
i82092-wire-up-errors-from-pci_register_driver.patch
config_pm=n-slim-drivers-serial-8250_pcic.patch
megaraid-fix-warnings-when-config_proc_fs=n.patch
turn-usb_resume_both-into-static-inline.patch
git-xfs.patch
sh-fix-fpn_start-typo.patch
headers_check-improve-include-regexp.patch
headers_check-clarify-error-message.patch
task_struct-ifdef-missedem-v-ipc.patch
ifdef-blktrace-debugging-fields.patch
tty_ioc-keep-davej-sane.patch
ifdef-quota_read-quota_write.patch
reiserfs-ifdef-xattr_sem.patch
reiserfs-ifdef-acl-stuff-from-inode.patch
fsh-ifdef-security-fields.patch
config_pm=n-slim-drivers-parport-parport_serialc.patch
config_pm=n-slim-sound-oss-tridentc.patch
config_pm=n-slim-sound-oss-cs46xxc.patch
windfarm_smu_satc-simplify-around-i2c_add_driver.patch
remove-null-check-in-register_nls.patch
config_pm=n-slim-drivers-ide-pci-sc1200c.patch
fs-kconfig-split-ext2.patch
fs-kconfig-split-ext3.patch
fs-kconfig-split-jbd.patch
fs-kconfig-split-reiserfs.patch
fs-kconfig-split-jfs.patch
fs-kconfig-split-ocfs2.patch
fs-kconfig-split-minix.patch
fs-kconfig-split-romfs.patch
fs-kconfig-split-autofs.patch
fs-kconfig-split-autofs4.patch
fs-kconfig-split-fuse.patch
fs-kconfig-split-isofs.patch
fs-kconfig-split-udf.patch
fs-kconfig-split-fat.patch
fs-kconfig-split-msdos.patch
fs-kconfig-split-vfat.patch
fs-kconfig-split-ntfs.patch
fs-kconfig-split-proc.patch
fs-kconfig-split-sysfs.patch
fs-kconfig-split-hugetlbfs.patch
fs-kconfig-split-ramfs.patch
fs-kconfig-split-configfs.patch
fs-kconfig-split-adfs.patch
fs-kconfig-split-affs.patch
fs-kconfig-split-ecryptfs.patch
fs-kconfig-split-hfs.patch
fs-kconfig-split-hfsplus.patch
fs-kconfig-split-befs.patch
fs-kconfig-split-bfs.patch
fs-kconfig-split-efs.patch
fs-kconfig-split-jffs.patch
fs-kconfig-split-jffs2.patch
fs-kconfig-split-cramfs.patch
fs-kconfig-split-freevxfs.patch
fs-kconfig-split-hpfs.patch
fs-kconfig-split-qnx4.patch
fs-kconfig-split-sysv.patch
fs-kconfig-split-ufs.patch
fs-kconfig-split-smbfs.patch
fs-kconfig-split-cifs.patch
fs-kconfig-split-ncpfs.patch
fs-kconfig-split-coda.patch
fs-kconfig-split-afs.patch
fs-kconfig-split-9p.patch
documentation-ioctl-messtxt-start-tree-wide-ioctl-registry.patch
ioctl-messtxt-xfs-typos.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
