The patch titled
ACPI: fix potential OOPS in power driver
has been added to the -mm tree. Its filename is
acpi-fix-potential-oops-in-power-driver.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: ACPI: fix potential OOPS in power driver
From: Dmitry Torokhov <dtor@xxxxxxxxxxxxx>
ACPI is littered with useless itialization of _every_ variable on the
stack. Besides increasing code it also sometimes covers real bugs.
Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
Cc: "Brown, Len" <len.brown@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/acpi/power.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff -puN drivers/acpi/power.c~acpi-fix-potential-oops-in-power-driver drivers/acpi/power.c
--- a/drivers/acpi/power.c~acpi-fix-potential-oops-in-power-driver
+++ a/drivers/acpi/power.c
@@ -216,10 +216,8 @@ static int acpi_power_off_device(acpi_ha
{
int result = 0;
acpi_status status = AE_OK;
- struct acpi_device *device = NULL;
struct acpi_power_resource *resource = NULL;
-
result = acpi_power_get_context(handle, &resource);
if (result)
return result;
@@ -230,13 +228,13 @@ static int acpi_power_off_device(acpi_ha
if (resource->references) {
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
"Resource [%s] is still in use, dereferencing\n",
- device->pnp.bus_id));
+ resource->device->pnp.bus_id));
return 0;
}
if (resource->state == ACPI_POWER_RESOURCE_STATE_OFF) {
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Resource [%s] already off\n",
- device->pnp.bus_id));
+ resource->device->pnp.bus_id));
return 0;
}
@@ -251,8 +249,7 @@ static int acpi_power_off_device(acpi_ha
return -ENOEXEC;
/* Update the power resource's _device_ power state */
- device = resource->device;
- device->power.state = ACPI_STATE_D3;
+ resource->device->power.state = ACPI_STATE_D3;
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Resource [%s] turned off\n",
resource->name));
_
Patches currently in -mm which might be from dtor@xxxxxxxxxxxxx are
acpi-fix-potential-oops-in-power-driver.patch
git-input.patch
input-i8042-get-rid-of-polling-timer.patch
hdaps-handle-errors-from-input_register_device.patch
ucb1x00-ts-handle-errors-from-input_register_device.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
