The patch titled
aic7xxx: fix byte I/O order in ahd_inw
has been added to the -mm tree. Its filename is
aic7xxx-fix-byte-i-o-order-in-ahd_inw.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: aic7xxx: fix byte I/O order in ahd_inw
From: Denis Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Comment says "Read high byte first as some registers increment..."
but code doesn't guarantee that, I think:
return ((ahd_inb(ahd, port+1) << 8) | ahd_inb(ahd, port));
Compiler can reorder it.
Make the order explicit.
Signed-off-by: Denis Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
drivers/scsi/aic7xxx/aic79xx_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/aic7xxx/aic79xx_core.c~aic7xxx-fix-byte-i-o-order-in-ahd_inw drivers/scsi/aic7xxx/aic79xx_core.c
--- a/drivers/scsi/aic7xxx/aic79xx_core.c~aic7xxx-fix-byte-i-o-order-in-ahd_inw
+++ a/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -323,7 +323,9 @@ ahd_inw(struct ahd_softc *ahd, u_int por
* or have other side effects when the low byte is
* read.
*/
- return ((ahd_inb(ahd, port+1) << 8) | ahd_inb(ahd, port));
+ uint16_t r = ahd_inb(ahd, port+1) << 8;
+ r |= ahd_inb(ahd, port);
+ return r;
}
void
_
Patches currently in -mm which might be from vda.linux@xxxxxxxxxxxxxx are
aic7xxx-fix-byte-i-o-order-in-ahd_inw.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
