The patch titled ieee1394: sbp2: update includes has been added to the -mm tree. Its filename is ieee1394-sbp2-update-includes.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: ieee1394: sbp2: update includes From: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> Remove unused includes. Add missing includes, i.e. explicitly include all used headers. Sort includes alphabetically. Replace one call to signal_pending(current) to avoid to include headers just for this line. Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> Cc: Jody McIntyre <scjody@xxxxxxxxxxxxxx> Cc: Ben Collins <bcollins@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/ieee1394/sbp2.c | 49 ++++++++++++++++++++------------------ 1 files changed, 27 insertions(+), 22 deletions(-) diff -puN drivers/ieee1394/sbp2.c~ieee1394-sbp2-update-includes drivers/ieee1394/sbp2.c --- a/drivers/ieee1394/sbp2.c~ieee1394-sbp2-update-includes +++ a/drivers/ieee1394/sbp2.c @@ -38,31 +38,36 @@ * but the code needs additional debugging. */ +#include <linux/blkdev.h> +#include <linux/compiler.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/dma-mapping.h> +#include <linux/gfp.h> +#include <linux/init.h> #include <linux/kernel.h> #include <linux/list.h> -#include <linux/string.h> -#include <linux/stringify.h> -#include <linux/slab.h> -#include <linux/interrupt.h> -#include <linux/fs.h> -#include <linux/poll.h> #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/types.h> -#include <linux/delay.h> -#include <linux/sched.h> -#include <linux/blkdev.h> -#include <linux/smp_lock.h> -#include <linux/init.h> #include <linux/pci.h> +#include <linux/slab.h> +#include <linux/spinlock.h> +#include <linux/stat.h> +#include <linux/string.h> +#include <linux/stringify.h> +#include <linux/types.h> #include <linux/wait.h> -#include <asm/current.h> -#include <asm/uaccess.h> -#include <asm/io.h> #include <asm/byteorder.h> -#include <asm/system.h> +#include <asm/errno.h> +#include <asm/param.h> #include <asm/scatterlist.h> +#include <asm/system.h> +#include <asm/types.h> + +#ifdef CONFIG_IEEE1394_SBP2_PHYS_DMA +#include <asm/io.h> /* for bus_to_virt */ +#endif #include <scsi/scsi.h> #include <scsi/scsi_cmnd.h> @@ -71,13 +76,14 @@ #include <scsi/scsi_host.h> #include "csr1212.h" +#include "highlevel.h" +#include "hosts.h" #include "ieee1394.h" -#include "ieee1394_types.h" #include "ieee1394_core.h" -#include "nodemgr.h" -#include "hosts.h" -#include "highlevel.h" +#include "ieee1394_hotplug.h" #include "ieee1394_transactions.h" +#include "ieee1394_types.h" +#include "nodemgr.h" #include "sbp2.h" /* @@ -1021,8 +1027,7 @@ static int sbp2_start_device(struct scsi * connected to the sbp2 device being removed. That host would * have a certain amount of time to relogin before the sbp2 device * allows someone else to login instead. One second makes sense. */ - msleep_interruptible(1000); - if (signal_pending(current)) { + if (msleep_interruptible(1000)) { sbp2_remove_device(scsi_id); return -EINTR; } _ Patches currently in -mm which might be from stefanr@xxxxxxxxxxxxxxxxx are git-ieee1394.patch ieee1394-fix-kerneldoc-of-hpsb_alloc_host.patch ieee1394-shrink-tlabel-pools-remove-tpool-semaphores.patch ieee1394-remove-include-asm-semaphoreh.patch ieee1394-sbp2-safer-last_orb-and.patch ieee1394-sbp2-discard-return-value-of.patch ieee1394-sbp2-optimize-dma-direction-of.patch ieee1394-sbp2-safer-initialization-of.patch ieee1394-sbp2-more-checks-of-status.patch ieee1394-sbp2-convert.patch ieee1394-safer-definition-of-empty-macros.patch ieee1394-sbp2-workaround-for-write-protect-bit-of.patch ieee1394-sbp2-enable-auto-spin-up-for-all-sbp-2-devices.patch config_pm=n-slim-drivers-ieee1394-ohci1394c.patch the-scheduled-removal-of-drivers-ieee1394-sbp2cforce_inquiry_hack.patch ieee1394-sbp2-handle-sbp2util_node_write_no_wait-failed.patch ieee1394-sbp2-safer-agent-reset-in-error-handlers.patch ieee1394-sbp2-recheck-node-generation-in-sbp2_update.patch ieee1394-sbp2-better-handling-of-transport-errors.patch ieee1394-sbp2-select-scsi-in-kconfig.patch ieee1394-sbp2-update-includes.patch ieee1394-sbp2-prevent-rare-deadlock-in-shutdown.patch initialize-ieee1394-early-when-built-in.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html