The patch titled libsas: externs not needed has been added to the -mm tree. Its filename is libsas-externs-not-needed.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: libsas: externs not needed From: Randy Dunlap <rdunlap@xxxxxxxxxxxx> These functions shouldn't be 'extern'. That's not needed for exports in Linux. Also, sparse complains, so fix them. drivers/scsi/libsas/sas_init.c:138:39: warning: function 'sas_domain_attach_transport' with external linkage has definition drivers/scsi/libsas/sas_init.c:158:13: warning: function 'sas_domain_release_transport' with external linkage has definitio Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/scsi/libsas/sas_init.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/libsas/sas_init.c~libsas-externs-not-needed drivers/scsi/libsas/sas_init.c --- a/drivers/scsi/libsas/sas_init.c~libsas-externs-not-needed +++ a/drivers/scsi/libsas/sas_init.c @@ -135,7 +135,7 @@ int sas_unregister_ha(struct sas_ha_stru static struct sas_function_template sft = { }; -extern struct scsi_transport_template * +struct scsi_transport_template * sas_domain_attach_transport(struct sas_domain_function_template *dft) { struct scsi_transport_template *stt = sas_attach_transport(&sft); @@ -155,7 +155,7 @@ sas_domain_attach_transport(struct sas_d EXPORT_SYMBOL_GPL(sas_domain_attach_transport); -extern void sas_domain_release_transport(struct scsi_transport_template *stt) +void sas_domain_release_transport(struct scsi_transport_template *stt) { sas_release_transport(stt); } _ Patches currently in -mm which might be from rdunlap@xxxxxxxxxxxx are acpi-bus-add-missing-newline.patch acpi-handle-firmware_register-init-errors.patch acpi-scan-handle-kset-kobject-errors.patch acpi-fix-printk-format-warnings.patch sysfs_remove_bin_file-no-return-value-dump_stack-on.patch kobject-must_check-fixes.patch drivers-base-check-errors.patch sysfs-add-proper-sysfs_init-prototype.patch bttv-must_check-fixes.patch git-lxdialog.patch pcmcia-ds-must_check-fixes.patch libsas-externs-not-needed.patch pcie-check-and-return-bus_register-errors.patch pcie-check-and-return-bus_register-errors-fix.patch git-scsi-misc.patch aic7-cleanup-module_parm_desc-strings.patch dc395x-fix-printk-format-warning.patch add-kerneldocs-for-some-functions-in-mm-memoryc.patch tiacx-sparse-cleanups.patch consistently-use-max_errno-in-__syscall_return.patch consistently-use-max_errno-in-__syscall_return-fix.patch eisa-bus-modalias-attributes-support-1.patch kernel-params-must_check-fixes.patch blockdevc-check-errors.patch block-handle-subsystem_register-init-errors.patch fs-namespace-handle-init-registration-errors.patch kernel-doc-for-relay-interface.patch kernel-doc-fixes-for-debugfs.patch kernel-doc-move-filesystems-together.patch include-documentation-for-functions-in-drivers-base-classc.patch fix-parameter-names-in-drivers-base-classc.patch fix-kerneldoc-comments-in-kernel-timerc-fix.patch ecryptfs-fix-printk-format-warnings.patch ide-core-must_check-fixes.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html