The patch titled There is no devfs, there has never been a devfs, we have always been at war with... has been added to the -mm tree. Its filename is there-is-no-devfs-there-has-never-been-a-devfs-we-have.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: There is no devfs, there has never been a devfs, we have always been at war with... From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Jon Smirl noted a couple of tty driver functions now are quite misleadingly named with the death of devfs. A quick grep found another case in the lp driver. Signed-off-by: Alan Cox <alan@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/char/lp.c | 4 ++-- drivers/char/vc_screen.c | 5 +++-- drivers/char/vt.c | 10 +++++----- 3 files changed, 10 insertions(+), 9 deletions(-) diff -puN drivers/char/lp.c~there-is-no-devfs-there-has-never-been-a-devfs-we-have drivers/char/lp.c --- a/drivers/char/lp.c~there-is-no-devfs-there-has-never-been-a-devfs-we-have +++ a/drivers/char/lp.c @@ -906,7 +906,7 @@ static int __init lp_init (void) lp_class = class_create(THIS_MODULE, "printer"); if (IS_ERR(lp_class)) { err = PTR_ERR(lp_class); - goto out_devfs; + goto out_reg; } if (parport_register_driver (&lp_driver)) { @@ -927,7 +927,7 @@ static int __init lp_init (void) out_class: class_destroy(lp_class); -out_devfs: +out_reg: unregister_chrdev(LP_MAJOR, "lp"); return err; } diff -puN drivers/char/vc_screen.c~there-is-no-devfs-there-has-never-been-a-devfs-we-have drivers/char/vc_screen.c --- a/drivers/char/vc_screen.c~there-is-no-devfs-there-has-never-been-a-devfs-we-have +++ a/drivers/char/vc_screen.c @@ -474,14 +474,15 @@ static const struct file_operations vcs_ static struct class *vc_class; -void vcs_make_devfs(struct tty_struct *tty) +void vcs_make_sysfs(struct tty_struct *tty) { device_create(vc_class, NULL, MKDEV(VCS_MAJOR, tty->index + 1), "vcs%u", tty->index + 1); device_create(vc_class, NULL, MKDEV(VCS_MAJOR, tty->index + 129), "vcsa%u", tty->index + 1); } -void vcs_remove_devfs(struct tty_struct *tty) + +void vcs_remove_sysfs(struct tty_struct *tty) { device_destroy(vc_class, MKDEV(VCS_MAJOR, tty->index + 1)); device_destroy(vc_class, MKDEV(VCS_MAJOR, tty->index + 129)); diff -puN drivers/char/vt.c~there-is-no-devfs-there-has-never-been-a-devfs-we-have drivers/char/vt.c --- a/drivers/char/vt.c~there-is-no-devfs-there-has-never-been-a-devfs-we-have +++ a/drivers/char/vt.c @@ -128,8 +128,8 @@ const struct consw *conswitchp; #define DEFAULT_BELL_PITCH 750 #define DEFAULT_BELL_DURATION (HZ/8) -extern void vcs_make_devfs(struct tty_struct *tty); -extern void vcs_remove_devfs(struct tty_struct *tty); +extern void vcs_make_sysfs(struct tty_struct *tty); +extern void vcs_remove_sysfs(struct tty_struct *tty); extern void console_map_init(void); #ifdef CONFIG_PROM_CONSOLE @@ -2498,7 +2498,7 @@ static int con_open(struct tty_struct *t tty->winsize.ws_col = vc_cons[currcons].d->vc_cols; } release_console_sem(); - vcs_make_devfs(tty); + vcs_make_sysfs(tty); return ret; } } @@ -2511,7 +2511,7 @@ static int con_open(struct tty_struct *t * and taking a ref against the tty while we're in the process of forgetting * about it and cleaning things up. * - * This is because vcs_remove_devfs() can sleep and will drop the BKL. + * This is because vcs_remove_sysfs() can sleep and will drop the BKL. */ static void con_close(struct tty_struct *tty, struct file *filp) { @@ -2524,7 +2524,7 @@ static void con_close(struct tty_struct vc->vc_tty = NULL; tty->driver_data = NULL; release_console_sem(); - vcs_remove_devfs(tty); + vcs_remove_sysfs(tty); mutex_unlock(&tty_mutex); /* * tty_mutex is released, but we still hold BKL, so there is _ Patches currently in -mm which might be from alan@xxxxxxxxxxxxxxxxxxx are origin.patch git-libata-all.patch 1-of-2-jmicron-driver.patch 2-of-2-jmicron-driver-plumbing-and-quirk.patch non-libata-driver-for-jmicron-devices.patch via-pata-controller-xfer-fixes.patch rework-legacy-handling-to-remove-much-of-the-cruft.patch rework-legacy-handling-to-remove-much-of-the-cruft-fix.patch rework-legacy-handling-to-remove-much-of-the-cruft-fix-2.patch add-full-compact-flash-support-to-libata.patch megaraid-gcc-41-warning-fix.patch edac-new-opteron-athlon64-memory-controller-driver.patch edac-new-opteron-athlon64-memory-controller-driver-tidy.patch sanitize-3c589_cs.patch make-prot_write-imply-prot_read.patch sgiioc4-fixup-use-of-mmio-ops.patch remove-unused-tty_struct-variable.patch there-is-no-devfs-there-has-never-been-a-devfs-we-have.patch ide-claim-extra-dma-ports-regardless-of-channel.patch ide-always-release-dma-engine.patch ide-error-handling-fixes.patch ide-hpt3xxn-clocking-fixes.patch ide-fix-hpt37x-timing-tables.patch ide-optimize-hpt37x-timing-tables.patch ide-fix-hpt3xx-hotswap-support.patch ide-fix-the-case-of-multiple-hpt3xx-chips-present.patch ide-hpt3xx-fix-pci-clock-detection.patch ide-hpt3xx-fix-pci-clock-detection-fix-2.patch piix-fix-82371mx-enablebits.patch piix-remove-check-for-broken-mw-dma-mode-0.patch piix-slc90e66-pio-mode-fallback-fix.patch make-number-of-ide-interfaces-configurable.patch ide_dma_speed-fixes.patch hpt3xx-rework-rate-filtering.patch hpt3xx-rework-rate-filtering-tidy.patch hpt3xx-print-the-real-chip-name-at-startup.patch hpt3xx-switch-to-using-pci_get_slot.patch hpt3xx-cache-channels-mcr-address.patch hpt3x7-merge-speedproc-handlers.patch hpt370-clean-up-dma-timeout-handling.patch enable-cdrom-dma-access-with-pdc20265_old.patch ide-fix-revision-comparison-in-ide_in_drive_list.patch ide-backport-piix-fixes-from-libata-into-the-legacy-driver.patch hpt3xx-init-code-rewrite.patch move-ide-to-unmaintained-drop-reference-to-old-git-tree.patch drivers-ide-cleanups.patch ide-remove-dma_base2-field-from-ide_hwif_t.patch ide-reprogram-disk-pio-timings-on-resume.patch asus-mv-ide-device-ids.patch ide-support-for-via-8237a-southbridge.patch revert-tty-buffering-comment-out-debug-code.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html